You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:55:01 UTC
[GitHub] [hadoop-ozone] smengcl opened a new pull request #1046: [WIP] HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
smengcl opened a new pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046
## What changes were proposed in this pull request?
Address merge conflicts after HDDS-3627
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3767
## How was this patch tested?
Existing tests should do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl edited a comment on pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-641468114
Note: I will manually push the merge commit https://github.com/apache/hadoop-ozone/pull/1046/commits/f229222a3243ca394e394d7e81345265af793bc3 to feature branch first when reviewed. Then squash merge this PR to avoid problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl edited a comment on pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl edited a comment on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-642120503
> Thanks this patch @smengcl (And sorry for the master changes, we worked paralell.)
>
> Understanding this PR is really challenging. Finally, I fetched the PR branch and compared with the master and everything seems to be the right place.
Thanks for the review @elek . Actually I put a [compare link](https://github.com/smengcl/hadoop-ozone/compare/HDDS-2665-ofs...HDDS-3767) in a previous comment which should have make the review easier in theory.
>
> One question: Why did you deleted `TestRootedOzoneFileSystemWithMocks.java`?
I removed `TestRootedOzoneFileSystemWithMocks.java` because HDDS-3627 removed `TestOzoneFileSystemWithMocks.java`.
I have just restored `TestRootedOzoneFileSystemWithMocks.java` under `ozonefs`.
>
> And one comment: `META-INF/services/...FileSystem` entries can be created for ofs, too. (In the future)
I believe we could only put one implementation [here](https://github.com/apache/hadoop-ozone/blob/072370b947416d89fae11d00a84a1d9a6b31beaa/hadoop-ozone/ozonefs/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem#L16)? Maybe later we can replace `org.apache.hadoop.fs.ozone.OzoneFileSystem` with `org.apache.hadoop.fs.ozone.RootedOzoneFileSystem`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on pull request #1046: [WIP] HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-641460297
@elek Please kindly take a look at my effort on rebasing OFS branch after HDDS-3627. I have did a `git merge master` on the OFS branch. Then added some commits. Quick diff for easier review:
https://github.com/smengcl/hadoop-ozone/compare/HDDS-2665-ofs...HDDS-3767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-642797900
Thanks @elek for reviewing and merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl closed pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl closed pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-641468114
Note: I will push the merge commit to feature branch first when reviewed. Then squash merge this PR to avoid problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] smengcl commented on pull request #1046: HDDS-3767. [OFS] Address merge conflicts after HDDS-3627
Posted by GitBox <gi...@apache.org>.
smengcl commented on pull request #1046:
URL: https://github.com/apache/hadoop-ozone/pull/1046#issuecomment-642120503
> Thanks this patch @smengcl (And sorry for the master changes, we worked paralell.)
>
> Understanding this PR is really challenging. Finally, I fetched the PR branch and compared with the master and everything seems to be the right place.
Thanks for the review @elek . Actually I put a [compare link](https://github.com/smengcl/hadoop-ozone/compare/HDDS-2665-ofs...HDDS-3767) in a previous comment which should have make the review easier in theory.
>
> One question: Why did you deleted `TestRootedOzoneFileSystemWithMocks.java`?
I removed `TestRootedOzoneFileSystemWithMocks.java` because HDDS-3627 removed `TestOzoneFileSystemWithMocks.java`. Shall we put it back?
>
> And one comment: `META-INF/services/...FileSystem` entries can be created for ofs, too. (In the future)
I believe we could only put one implementation [here](https://github.com/apache/hadoop-ozone/blob/072370b947416d89fae11d00a84a1d9a6b31beaa/hadoop-ozone/ozonefs/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem#L16)? Maybe later we can replace `org.apache.hadoop.fs.ozone.OzoneFileSystem` with `org.apache.hadoop.fs.ozone.RootedOzoneFileSystem`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org