You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "lxwcodemonkey (via GitHub)" <gi...@apache.org> on 2023/08/14 06:55:09 UTC

[GitHub] [doris-spark-connector] lxwcodemonkey opened a new pull request, #126: [improvement] set streamLoad prop num_as_string default true to avoid…

lxwcodemonkey opened a new pull request, #126:
URL: https://github.com/apache/doris-spark-connector/pull/126

   … loss of floating point precision
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris-spark-connector] lxwcodemonkey commented on pull request #126: [improvement] set streamLoad prop num_as_string default true to avoid…

Posted by "lxwcodemonkey (via GitHub)" <gi...@apache.org>.
lxwcodemonkey commented on PR #126:
URL: https://github.com/apache/doris-spark-connector/pull/126#issuecomment-1681476345

   @JNSimba Could you help me to have a look? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement] set streamLoad prop num_as_string default true to avoid… [doris-spark-connector]

Posted by "lxwcodemonkey (via GitHub)" <gi...@apache.org>.
lxwcodemonkey closed pull request #126: [improvement] set streamLoad prop num_as_string default true to avoid…
URL: https://github.com/apache/doris-spark-connector/pull/126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris-spark-connector] JNSimba commented on pull request #126: [improvement] set streamLoad prop num_as_string default true to avoid…

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #126:
URL: https://github.com/apache/doris-spark-connector/pull/126#issuecomment-1681744420

   Thank you for your contribution. Is it better to modify the default value directly on the streamload side?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org