[jira] [Commented] (AVRO-1608) Deprecate mutator methods on Schema

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253754#comment-14253754 ] 

Doug Cutting commented on AVRO-1608:
------------------------------------

This is looking good, Tom.  The non-mutating schema constructors work well.

To test that we haven't broken compatibility I reverted changes to tests and they still all passed.

> Deprecate mutator methods on Schema
> -----------------------------------
>
>                 Key: AVRO-1608
>                 URL: https://issues.apache.org/jira/browse/AVRO-1608
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 1.7.8
>
>         Attachments: AVRO-1608.patch, AVRO-1608.patch
>
>
> This is a follow on to AVRO-261. It would be good to deprecate JsonProperties#addProp, Schema#addAlias, and Schema.Field#addAlias, and remove them in 1.8.0. Instead users should use SchemaBuilder, or we could also provide overloaded variants of the factory methods on Schema to specify properties and aliases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)