You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/08 23:19:52 UTC
[GitHub] [maven-pmd-plugin] TobiTenno opened a new pull request #39: [MPMD-311] - Improve excludeFileFromFailure docs
TobiTenno opened a new pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39
Improve the documentation around `exclude-cpd.properties` file formatting
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] TobiTenno commented on a change in pull request #39: [MPMD-311] - Improve excludeFileFromFailure docs
Posted by GitBox <gi...@apache.org>.
TobiTenno commented on a change in pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39#discussion_r542635482
##########
File path: src/site/apt/examples/violation-exclusions.apt.vm
##########
@@ -63,9 +63,15 @@ Violation Exclusions
+-----+
For cpd check, you can exclude classes to not verify. The properties file must have the following format:
+
+ The differences here are that:
Review comment:
Looks awesome, thank you very much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel merged pull request #39: [MPMD-311] - Improve excludeFileFromFailure docs
Posted by GitBox <gi...@apache.org>.
adangel merged pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #39: [MPMD-311] - Improve excludeFileFromFailure docs
Posted by GitBox <gi...@apache.org>.
adangel commented on a change in pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39#discussion_r540873693
##########
File path: src/site/apt/examples/violation-exclusions.apt.vm
##########
@@ -63,9 +63,15 @@ Violation Exclusions
+-----+
For cpd check, you can exclude classes to not verify. The properties file must have the following format:
+
+ The differences here are that:
Review comment:
I'd rephrase this a bit:
```
For cpd check, you can exclude classes to not verify. Classes can be specified in two ways:
[[1]] Comma-separated: org.apache.maven.ClassA and org.apache.maven.ClassB contain duplicated code across classes.
[[2]] Single class per line: org.apache.maven.ClassC and org.apache.maven.ClassD do not share duplicate code, but have duplicated code internally.
The properties file for cpd must have the following format:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-pmd-plugin] adangel commented on pull request #39: [MPMD-311] - Improve excludeFileFromFailure docs
Posted by GitBox <gi...@apache.org>.
adangel commented on pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39#issuecomment-743142904
Thanks! This will be part in the next version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org