[GitHub] [druid] vogievetsky commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments
URL: https://github.com/apache/druid/pull/7306#discussion_r369988988
 
 

 ##########
 File path: web-console/src/views/datasource-view/datasource-view.tsx
 ##########
 @@ -346,104 +348,103 @@ GROUP BY 1`;
     this.datasourceQueryManager.terminate();
   }
 
-  renderDropDataAction() {
-    const { dropDataDatasource } = this.state;
-    if (!dropDataDatasource) return;
+  renderUnuseAction() {
+    const { dataSourceToMarkAsUnusedAllSegmentsIn } = this.state;
+    if (!dataSourceToMarkAsUnusedAllSegmentsIn) return;
 
     return (
       <AsyncActionDialog
         action={async () => {
           const resp = await axios.delete(
-            `/druid/coordinator/v1/datasources/${dropDataDatasource}`,
+            `/druid/coordinator/v1/datasources/${dataSourceToMarkAsUnusedAllSegmentsIn}`,
             {},
           );
           return resp.data;
         }}
-        confirmButtonText="Drop data"
-        successText="Data drop request acknowledged, next time the coordinator runs data will be dropped"
-        failText="Could not drop data"
+        confirmButtonText="Mark as unused all segments in data source"
 
 Review comment:
   This is way too long to be a button. Maybe just call it "Mark as unused" and make sure to specify what is going on in the text of the dialog (which you are mostly doing already)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org