You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/26 16:18:22 UTC
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps opened a new pull
request #632: (android) Added option to turn on/off fullscreen mode in
Android
PDLMobileApps opened a new pull request #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
Resolves #598
<!-- If it fixes an open issue, please link to the issue here. -->
https://github.com/apache/cordova-plugin-inappbrowser/issues/598
### Description
<!-- Describe your changes in detail -->
This PR adds a new Android option (fullscreen - yes/no) to enable/disable the fullscreen WebView on Android. The default value is no.
Testing was done manually as I am not sure on how to automate it.
### Testing
<!-- Please describe in detail how you tested your changes. -->
1. Created a new Cordova test app using cordova-plugin-inappbrowser.
2. Executed:
`cordova.InAppBrowser.open(url, "_blank", "");`
and verified the WebView is not opening in fullscreen mode.
3. Executed:
`cordova.InAppBrowser.open(url, "_blank", "fullscreen=no");`
and verified the WebView is not opening in fullscreen mode.
4. Executed:
`cordova.InAppBrowser.open(url, "_blank", "fullscreen=yes");`
and verified the WebView is opening in fullscreen mode.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Smokolisz edited a comment on issue
#632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
Smokolisz edited a comment on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591636241
@PDLMobileApps can you please try to reproduce my problem? Simply create new cordova 9.0.0 project and add inappbrowser plugin. After device ready fire webview:
`inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no');
ref.show();`
It opens in fullscreen in emulator and on normal phone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps closed pull request
#632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps closed pull request #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Smokolisz commented on issue #632:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
Smokolisz commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591636241
@PDLMobileApps can you please try to reproduce my problem? Simply create new cordova 9.0.0 project and add inappbrowser plugin. After device ready fire webview:
`inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no');
ref.show();`
It opens in fullscreen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Smokolisz commented on issue #632:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
Smokolisz commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591641761
@PDLMobileApps well in my project it opens in fullscreen, but now i checked version 3.0.0 and it works fine (without fullscreen) so i will just stick with it. Thank you for your time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] breautek commented on issue #632:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-592091702
Are the last two commmits (https://github.com/apache/cordova-plugin-inappbrowser/pull/632/commits/0982cd1b60f0365c04ae2c37756576c06e31a381 & https://github.com/apache/cordova-plugin-inappbrowser/pull/632/commits/4b2e286f2bc02d38ec6cdf2808015e1fc955e988) related to this PR?
If not, they'll need to be removed to make this PR valid again. If so, the PR description will have to be updated to describe the changes being done in iOS.
I'd recommend creating a branch for this feature and apply the PR commit against the new branch. This will require you to submit a new PR however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on issue
#632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-592111154
> Are the last two commmits ([0982cd1](https://github.com/apache/cordova-plugin-inappbrowser/commit/0982cd1b60f0365c04ae2c37756576c06e31a381) & [4b2e286](https://github.com/apache/cordova-plugin-inappbrowser/commit/4b2e286f2bc02d38ec6cdf2808015e1fc955e988)) related to this PR?
>
> If not, they'll need to be removed to make this PR valid again. If so, the PR description will have to be updated to describe the changes being done in iOS.
>
> I'd recommend creating a branch for this feature and apply the PR commit against the new branch. This will require you to submit a new PR however.
Those commit are not releted to issue #598
I created a new PR based on a branch as you recommended: #634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on issue
#632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591640931
> @PDLMobileApps can you please try to reproduce my problem? Simply create new cordova 9.0.0 project and add inappbrowser plugin. After device ready fire webview:
> `inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no'); ref.show();`
> It opens in fullscreen in emulator and on normal phone
`inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no');` works just fine in Android, as you can see in this picture:
[https://drive.google.com/open?id=13jkc2UHQCe2_iyAsrsDj77pblLmv7F-A](url)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Smokolisz commented on issue #632:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
Smokolisz commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591626793
I have an issuse: i just created new cordova project and added inappbrowser plugin, which i was using in my previous apps and now the webView opens in fullscreen (without status bar) while rest of application has the statusbar. I think it is caused by this commit. I launch inappbrowser this way:
`var ref = cordova.InAppBrowser.open(url, '_blank', 'location=no', "fullscreen=no");`
i tried setting preference in config.xml
`<preference name="Fullscreen" value="false" />`
Sadly nothing worked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps edited a comment on
issue #632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps edited a comment on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591640931
> @PDLMobileApps can you please try to reproduce my problem? Simply create new cordova 9.0.0 project and add inappbrowser plugin. After device ready fire webview:
> `inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no'); ref.show();`
> It opens in fullscreen in emulator and on normal phone
`inAppBrowserRef = cordova.InAppBrowser.open("http://google.com", "_blank", 'location=no,fullscreen=no');` works just fine in Android, as you can see in this picture:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Smokolisz commented on issue #632:
(android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
Smokolisz commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591632394
> You have to call it like this:
> `var ref = cordova.InAppBrowser.open(url, '_blank', 'location=no,fullscreen=no');`
Ok i corrected it but it still opens in fullscreen mode every time. It quite doesn't look good when app have the status bar and then after inappbrowser starts it disappear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] PDLMobileApps commented on issue
#632: (android) Added option to turn on/off fullscreen mode in Android
Posted by GitBox <gi...@apache.org>.
PDLMobileApps commented on issue #632: (android) Added option to turn on/off fullscreen mode in Android
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/632#issuecomment-591629913
> I have an issuse: i just created new cordova project and added inappbrowser plugin, which i was using in my previous apps and now the webView opens in fullscreen (without status bar) while rest of application has the statusbar. I think it is caused by this commit. I launch inappbrowser this way:
> `var ref = cordova.InAppBrowser.open(url, '_blank', 'location=no', "fullscreen=no");`
>
> i tried setting preference in config.xml
> `<preference name="Fullscreen" value="false" />`
> Sadly nothing worked.
You have to call it like this:
`var ref = cordova.InAppBrowser.open(url, '_blank', 'location=no,fullscreen=no');`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org