You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Major Peter (JIRA)" <ji...@apache.org> on 2011/01/23 18:29:44 UTC

[jira] Created: (WICKET-3373) AbstractComponentMapper can't handle '//' in URLs

AbstractComponentMapper can't handle '//' in URLs 
--------------------------------------------------

                 Key: WICKET-3373
                 URL: https://issues.apache.org/jira/browse/WICKET-3373
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5-RC1
            Reporter: Major Peter
         Attachments: wicket-3373.tar.gz

If for some reason you have an URL with '//', then AbstractComponentMapper.getPageClass() on line 138 will fail for checking the 'name' argument, and will lead to an InvalidArgumentException. Based on http://www.ietf.org/rfc/rfc1738.txt the HTTP URL's have the following form:
; HTTP

httpurl        = "http://" hostport [ "/" hpath [ "?" search ]]
hpath          = hsegment *[ "/" hsegment ]
hsegment       = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search         = *[ uchar | ";" | ":" | "@" | "&" | "=" ]

Since '*' can be 0, hsegment can be empty, thus multiple / is allowed in URL's, so Wicket should be able to handle them.
See attachment for a simple example.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3373) AbstractComponentMapper can't handle '//' in URLs

Posted by "Major Peter (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Major Peter updated WICKET-3373:
--------------------------------

    Attachment: wicket-3373.tar.gz

> AbstractComponentMapper can't handle '//' in URLs 
> --------------------------------------------------
>
>                 Key: WICKET-3373
>                 URL: https://issues.apache.org/jira/browse/WICKET-3373
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Major Peter
>         Attachments: wicket-3373.tar.gz
>
>
> If for some reason you have an URL with '//', then AbstractComponentMapper.getPageClass() on line 138 will fail for checking the 'name' argument, and will lead to an InvalidArgumentException. Based on http://www.ietf.org/rfc/rfc1738.txt the HTTP URL's have the following form:
> ; HTTP
> httpurl        = "http://" hostport [ "/" hpath [ "?" search ]]
> hpath          = hsegment *[ "/" hsegment ]
> hsegment       = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
> search         = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
> Since '*' can be 0, hsegment can be empty, thus multiple / is allowed in URL's, so Wicket should be able to handle them.
> See attachment for a simple example.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-3373) AbstractComponentMapper can't handle '//' in URLs

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3373.
-------------------------------------

    Resolution: Invalid
      Assignee: Martin Grigorov

The RFC support is OK.
The problem is in the url itself.
/wicket/** is preserved namespace for special Wicket URLs like bookmarkable pages and resources.
These URLs have strongly specified expectations. If the url is created broken by Wicket then it is a bug. But since this url is created by other means it is not a problem in Wicket. 

> AbstractComponentMapper can't handle '//' in URLs 
> --------------------------------------------------
>
>                 Key: WICKET-3373
>                 URL: https://issues.apache.org/jira/browse/WICKET-3373
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC1
>            Reporter: Major Peter
>            Assignee: Martin Grigorov
>         Attachments: wicket-3373.tar.gz
>
>
> If for some reason you have an URL with '//', then AbstractComponentMapper.getPageClass() on line 138 will fail for checking the 'name' argument, and will lead to an InvalidArgumentException. Based on http://www.ietf.org/rfc/rfc1738.txt the HTTP URL's have the following form:
> ; HTTP
> httpurl        = "http://" hostport [ "/" hpath [ "?" search ]]
> hpath          = hsegment *[ "/" hsegment ]
> hsegment       = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
> search         = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
> Since '*' can be 0, hsegment can be empty, thus multiple / is allowed in URL's, so Wicket should be able to handle them.
> See attachment for a simple example.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.