You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Zilong Song (JIRA)" <ji...@apache.org> on 2017/03/05 18:03:32 UTC

[jira] [Updated] (LOG4J2-1838) Add support for appending common suffix to each line of throwable stack trace

     [ https://issues.apache.org/jira/browse/LOG4J2-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zilong Song updated LOG4J2-1838:
--------------------------------
    Description: 
Add support for appending common suffix to each line of throwable stack trace. The suffix can be configured by patterns just like patterns used elsewhere. 

For example, pattern {{%xEx\{suffix(- %mdc\{key\})\}}} will append a string generated by pattern {{- }} and pattern {{%mdc\{key\} }}.

But throwable patterns will be automatically ignored, because they will make the rendered result confusing. So pattern {{%xEx\{suffix(- %rEx%mdc\{key\})\}}} has the same effect with {{%xEx\{suffix(- %mdc\{key\})\}}}, as if the nested {{%rEx}} has never appeared.

With the common suffix, the stack trace is as following: (with pattern {{suffix(- %mdc\{key\})}}, and MDC value {{test mdc suffix}} to {{key}})

{code:title=stack trace|borderStyle=solid}
java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48) [test-classes/:?] - test mdc suffix
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test mdc suffix
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91] - test mdc suffix
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) [idea_rt.jar:?] - test mdc suffix
Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47) ~[test-classes/:?] - test mdc suffix
	... 27 more - test mdc suffix
}}
{code}

  was:
Add support for appending common suffix to each line of throwable stack trace. The suffix can be configured by patterns just like patterns used elsewhere. 

For example, pattern {{%xEx{suffix(- %mdc{key})}}} will append a string generated by pattern {{- }} and pattern {{%mdc{key}}}.

But throwable patterns will be automatically ignored, because they will make the rendered result confusing. So pattern {{%xEx{suffix(- %rEx%mdc{key})}}} has the same effect with {{%xEx{suffix(- %mdc{key})}}}, as if the nested {{%rEx}} has never appeared.

With the common suffix, the stack trace is as following: (with pattern {{suffix(- %mdc{key})}}, and MDC value {{test mdc suffix}} to {{key}})

{{
java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48) [test-classes/:?] - test mdc suffix
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test mdc suffix
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_91] - test mdc suffix
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91] - test mdc suffix
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363) [junit-4.12.jar:4.12] - test mdc suffix
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137) [junit-4.12.jar:4.12] - test mdc suffix
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68) [junit-rt.jar:?] - test mdc suffix
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51) [junit-rt.jar:?] - test mdc suffix
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237) [junit-rt.jar:?] - test mdc suffix
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70) [junit-rt.jar:?] - test mdc suffix
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test mdc suffix
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_91] - test mdc suffix
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91] - test mdc suffix
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) [idea_rt.jar:?] - test mdc suffix
Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47) ~[test-classes/:?] - test mdc suffix
	... 27 more - test mdc suffix
}}


> Add support for appending common suffix to each line of throwable stack trace
> -----------------------------------------------------------------------------
>
>                 Key: LOG4J2-1838
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1838
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Pattern Converters
>    Affects Versions: 2.8.1
>            Reporter: Zilong Song
>              Labels: features
>             Fix For: 2.8.2
>
>
> Add support for appending common suffix to each line of throwable stack trace. The suffix can be configured by patterns just like patterns used elsewhere. 
> For example, pattern {{%xEx\{suffix(- %mdc\{key\})\}}} will append a string generated by pattern {{- }} and pattern {{%mdc\{key\} }}.
> But throwable patterns will be automatically ignored, because they will make the rendered result confusing. So pattern {{%xEx\{suffix(- %rEx%mdc\{key\})\}}} has the same effect with {{%xEx\{suffix(- %mdc\{key\})\}}}, as if the nested {{%rEx}} has never appeared.
> With the common suffix, the stack trace is as following: (with pattern {{suffix(- %mdc\{key\})}}, and MDC value {{test mdc suffix}} to {{key}})
> {code:title=stack trace|borderStyle=solid}
> java.lang.IllegalArgumentException: IllegalArgument - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:48) [test-classes/:?] - test mdc suffix
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91] - test mdc suffix
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91] - test mdc suffix
> 	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91] - test mdc suffix
> 	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147) [idea_rt.jar:?] - test mdc suffix
> Caused by: java.lang.NullPointerException: null pointer - test mdc suffix
> 	at org.apache.logging.log4j.core.pattern.ExtendedThrowablePatternConverterTest.testSuffixFromNormalPattern(ExtendedThrowablePatternConverterTest.java:47) ~[test-classes/:?] - test mdc suffix
> 	... 27 more - test mdc suffix
> }}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org