You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by venkata swamy babu budumuru <ve...@citrix.com> on 2013/03/05 14:28:59 UTC
Review Request: CLOUDSTACK-1514 : Unable to remove secondary ips though
there are no PF rules associated with it
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9750/
-----------------------------------------------------------
Review request for cloudstack and Jayapal Reddy.
Description
-------
To reproduce this issue :
- Advanced Zone with latest master code
- single cluster with 1 XenServer
1. Have at least 1 VM deployed using ISOLATED network
2. add multiple ips to guest nic using "addIpToNic"
3. createPF rule on the first secondary ip
4. try to removeIpFromNic on second, third etc.., secondary ips
Observations:
i. It fails saying there are PF rules associated with it though it doesnt have any.
This addresses bug CLOUDSTACK-1514.
Diffs
-----
server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 1d2e991
Diff: https://reviews.apache.org/r/9750/diff/
Testing
-------
Retried the same scenario with the new cloud-server.jar that contains the new change. everything went fine
Thanks,
venkata swamy babu budumuru
Re: Review Request: CLOUDSTACK-1514 : Unable to remove secondary ips though
there are no PF rules associated with it
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
> On March 6, 2013, 5:01 a.m., Sateesh Chodapuneedi wrote:
> > Ship It!
Applied the patch to master branch.
Commit cdae53a28914507b32545b37b836ea5aca8bbd83
- Sateesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9750/#review17446
-----------------------------------------------------------
On March 5, 2013, 1:29 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9750/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 1:29 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Description
> -------
>
> To reproduce this issue :
>
> - Advanced Zone with latest master code
> - single cluster with 1 XenServer
>
> 1. Have at least 1 VM deployed using ISOLATED network
> 2. add multiple ips to guest nic using "addIpToNic"
> 3. createPF rule on the first secondary ip
> 4. try to removeIpFromNic on second, third etc.., secondary ips
>
> Observations:
>
> i. It fails saying there are PF rules associated with it though it doesnt have any.
>
>
> This addresses bug CLOUDSTACK-1514.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 1d2e991
>
> Diff: https://reviews.apache.org/r/9750/diff/
>
>
> Testing
> -------
>
> Retried the same scenario with the new cloud-server.jar that contains the new change. everything went fine
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1514 : Unable to remove secondary ips though
there are no PF rules associated with it
Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9750/#review17446
-----------------------------------------------------------
Ship it!
Ship It!
- Sateesh Chodapuneedi
On March 5, 2013, 1:29 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9750/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 1:29 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Description
> -------
>
> To reproduce this issue :
>
> - Advanced Zone with latest master code
> - single cluster with 1 XenServer
>
> 1. Have at least 1 VM deployed using ISOLATED network
> 2. add multiple ips to guest nic using "addIpToNic"
> 3. createPF rule on the first secondary ip
> 4. try to removeIpFromNic on second, third etc.., secondary ips
>
> Observations:
>
> i. It fails saying there are PF rules associated with it though it doesnt have any.
>
>
> This addresses bug CLOUDSTACK-1514.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 1d2e991
>
> Diff: https://reviews.apache.org/r/9750/diff/
>
>
> Testing
> -------
>
> Retried the same scenario with the new cloud-server.jar that contains the new change. everything went fine
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1514 : Unable to remove secondary ips though
there are no PF rules associated with it
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9750/#review17445
-----------------------------------------------------------
Ship it!
Ship It!
- Jayapal Reddy
On March 5, 2013, 1:29 p.m., venkata swamy babu budumuru wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9750/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 1:29 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
>
>
> Description
> -------
>
> To reproduce this issue :
>
> - Advanced Zone with latest master code
> - single cluster with 1 XenServer
>
> 1. Have at least 1 VM deployed using ISOLATED network
> 2. add multiple ips to guest nic using "addIpToNic"
> 3. createPF rule on the first secondary ip
> 4. try to removeIpFromNic on second, third etc.., secondary ips
>
> Observations:
>
> i. It fails saying there are PF rules associated with it though it doesnt have any.
>
>
> This addresses bug CLOUDSTACK-1514.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 1d2e991
>
> Diff: https://reviews.apache.org/r/9750/diff/
>
>
> Testing
> -------
>
> Retried the same scenario with the new cloud-server.jar that contains the new change. everything went fine
>
>
> Thanks,
>
> venkata swamy babu budumuru
>
>
Re: Review Request: CLOUDSTACK-1514 : Unable to remove secondary ips though
there are no PF rules associated with it
Posted by venkata swamy babu budumuru <ve...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9750/
-----------------------------------------------------------
(Updated March 5, 2013, 1:29 p.m.)
Review request for cloudstack, Abhinandan Prateek and Jayapal Reddy.
Description
-------
To reproduce this issue :
- Advanced Zone with latest master code
- single cluster with 1 XenServer
1. Have at least 1 VM deployed using ISOLATED network
2. add multiple ips to guest nic using "addIpToNic"
3. createPF rule on the first secondary ip
4. try to removeIpFromNic on second, third etc.., secondary ips
Observations:
i. It fails saying there are PF rules associated with it though it doesnt have any.
This addresses bug CLOUDSTACK-1514.
Diffs
-----
server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java 1d2e991
Diff: https://reviews.apache.org/r/9750/diff/
Testing
-------
Retried the same scenario with the new cloud-server.jar that contains the new change. everything went fine
Thanks,
venkata swamy babu budumuru