You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/05/17 19:30:24 UTC
[kudu-CR](branch-1.15.x) [txns][tools] show details of a transaction
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17468
Change subject: [txns][tools] show details of a transaction
......................................................................
[txns][tools] show details of a transaction
This adds a tool to show information related to a single transaction,
including metadata from all of its participants. The goal of this tool
is to be useful in debugging slow commits or inconsistencies with a
transaction.
Currently this outputs info stored in participant's metadata for the
transaction.
$ kudu txn show 0.0.0.0:7051 0
txn_id | user | state | commit_datetime
--------+-------+-----------+-------------------------------
0 | awong | COMMITTED | Fri, 14 May 2021 19:15:18 GMT
tablet_id | begin_commit_datetime | commit_datetime
----------------------------------+-------------------------------+-------------------------------
9204d93c0af14292843b6d432d281fb5 | Fri, 14 May 2021 19:15:18 GMT | Fri, 14 May 2021 19:15:18 GMT
The new tool abides by the --columns flag, as done with the
`kudu txn list` tool, with some additional options for
participant-specific columns.
Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Reviewed-on: http://gerrit.cloudera.org:8080/17391
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit b2633cac57e171e1ee0d98e1ecc3e41b8a2f8cd2)
---
M src/kudu/tools/kudu-txn-cli-test.cc
M src/kudu/tools/tool_action_txn.cc
2 files changed, 393 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/17468/1
--
To view, visit http://gerrit.cloudera.org:8080/17468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.15.x) [txns][tools] show details of a transaction
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17468 )
Change subject: [txns][tools] show details of a transaction
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 23:53:42 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [txns][tools] show details of a transaction
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17468 )
Change subject: [txns][tools] show details of a transaction
......................................................................
[txns][tools] show details of a transaction
This adds a tool to show information related to a single transaction,
including metadata from all of its participants. The goal of this tool
is to be useful in debugging slow commits or inconsistencies with a
transaction.
Currently this outputs info stored in participant's metadata for the
transaction.
$ kudu txn show 0.0.0.0:7051 0
txn_id | user | state | commit_datetime
--------+-------+-----------+-------------------------------
0 | awong | COMMITTED | Fri, 14 May 2021 19:15:18 GMT
tablet_id | begin_commit_datetime | commit_datetime
----------------------------------+-------------------------------+-------------------------------
9204d93c0af14292843b6d432d281fb5 | Fri, 14 May 2021 19:15:18 GMT | Fri, 14 May 2021 19:15:18 GMT
The new tool abides by the --columns flag, as done with the
`kudu txn list` tool, with some additional options for
participant-specific columns.
Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Reviewed-on: http://gerrit.cloudera.org:8080/17391
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/17468
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/tools/kudu-txn-cli-test.cc
M src/kudu/tools/tool_action_txn.cc
2 files changed, 393 insertions(+), 57 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [txns][tools] show details of a transaction
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17468 )
Change subject: [txns][tools] show details of a transaction
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 17 May 2021 21:10:53 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [txns][tools] show details of a transaction
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17468
to look at the new patch set (#2).
Change subject: [txns][tools] show details of a transaction
......................................................................
[txns][tools] show details of a transaction
This adds a tool to show information related to a single transaction,
including metadata from all of its participants. The goal of this tool
is to be useful in debugging slow commits or inconsistencies with a
transaction.
Currently this outputs info stored in participant's metadata for the
transaction.
$ kudu txn show 0.0.0.0:7051 0
txn_id | user | state | commit_datetime
--------+-------+-----------+-------------------------------
0 | awong | COMMITTED | Fri, 14 May 2021 19:15:18 GMT
tablet_id | begin_commit_datetime | commit_datetime
----------------------------------+-------------------------------+-------------------------------
9204d93c0af14292843b6d432d281fb5 | Fri, 14 May 2021 19:15:18 GMT | Fri, 14 May 2021 19:15:18 GMT
The new tool abides by the --columns flag, as done with the
`kudu txn list` tool, with some additional options for
participant-specific columns.
Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Reviewed-on: http://gerrit.cloudera.org:8080/17391
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tools/kudu-txn-cli-test.cc
M src/kudu/tools/tool_action_txn.cc
2 files changed, 393 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/17468/2
--
To view, visit http://gerrit.cloudera.org:8080/17468
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17468
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)