You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/29 06:32:22 UTC

[GitHub] [spark] maropu commented on issue #25615: [SPARK-28495][SQL][FOLLOW-UP] Disallow conversions between timestamp and long in ASNI mode

maropu commented on issue #25615: [SPARK-28495][SQL][FOLLOW-UP] Disallow conversions between timestamp and long in ASNI mode
URL: https://github.com/apache/spark/pull/25615#issuecomment-526045102
 
 
   The change looks reasonable to me. Just in case, I checked the pgSQL behaivour;
   ```
   postgres=# create table t (l bigint);
   postgres=# insert into t values ('20190829 00:00:00'::timestamp);
   2019-08-29 15:26:10.998 JST [4553] ERROR:  column "l" is of type bigint but expression is of type timestamp without time zone at character 23
   2019-08-29 15:26:10.998 JST [4553] HINT:  You will need to rewrite or cast the expression.
   2019-08-29 15:26:10.998 JST [4553] STATEMENT:  insert into t values ('20190829 00:00:00'::timestamp);
   ERROR:  column "l" is of type bigint but expression is of type timestamp without time zone
   LINE 1: insert into t values ('20190829 00:00:00'::timestamp);
                              
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org