You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "Rick Kellogg (JIRA)" <ji...@apache.org> on 2015/10/05 03:59:26 UTC
[jira] [Updated] (STORM-443) multilang log's loglevel protocol can
cause hang
[ https://issues.apache.org/jira/browse/STORM-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Kellogg updated STORM-443:
-------------------------------
Component/s: storm-multilang
> multilang log's loglevel protocol can cause hang
> -------------------------------------------------
>
> Key: STORM-443
> URL: https://issues.apache.org/jira/browse/STORM-443
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-multilang
> Affects Versions: 0.9.3
> Reporter: DashengJu
> Assignee: DashengJu
> Fix For: 0.9.3
>
>
> Storm now support logging level to multilang protocol spout and bolt. But the implementation is not compatible with old log protocol with no logging level.
> With old topology who use old protocol, when they send log with no loglevel, JsonSerializer's readShellMsg function will throw NPE at:
> if (command.equals("log")) {
> long logLevel = (Long)msg.get("level"); //throw NPE at here
> shellMsg.setLogLevel((int)logLevel);
> }
> ShellBolt will catch the NPE, and call die(), and die() will get error info from sub process's error stream in _process.getProcessTerminationInfoString(), but the error stream have no data come, it will hangs.
> private void die(Throwable exception) {
> String processInfo = _process.getProcessInfoString() + _process.getProcessTerminationInfoString();
> _exception = new RuntimeException(processInfo, exception);
> }
> This PR will fix the problem of log level implementation to compatible with old log protocol. And the die problem should be solved by [~xiaokang] 's PR https://github.com/apache/incubator-storm/pull/46
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)