You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Jeremy Levy <je...@gmail.com> on 2013/01/15 02:18:32 UTC
HttpsMapper broken with Mounted pages
I believe I may have stumbled upon somewhat serious issue with 6.4.0 (and
possibly earlier). A page that is annotated with @RequiresHttps and is
mounted with any encoding method, when requested directly, or linked to is
not switched over to https. If the page is not specifically mounted it
works as expected.
I was able to recreate this in my application as well as in a standalone
'quickstart' project. As far as I could see
HttpsMapper.getDesiredSchemeFor wasn't even being called for the mounted
pages.
I'll debug the issue tomorrow and submit a patch if I can figure it out,
however I thought this was serious enough to bring up here right away.
Jeremy
--
Jeremy Levy
Re: HttpsMapper broken with Mounted pages
Posted by Sven Meier <sv...@meiers.net>.
Thanks :)
On 01/15/2013 08:45 PM, Jeremy Levy wrote:
> Just to close the loop here. If setRootRequestMapper(new HttpsMapper... is
> done before you add your mounts, they will not be enabled for SSL. I've
> added and updated the Wiki to reflect this as well as requested the line in
> the javadoc where this is be mentioned be made more prominent.
>
> Jeremy
>
>
> On Tue, Jan 15, 2013 at 10:24 AM, Jeremy Levy <je...@gmail.com> wrote:
>
>> Thanks- Done.
>>
>> https://issues.apache.org/jira/browse/WICKET-4979
>>
>>
>> On Tue, Jan 15, 2013 at 3:05 AM, Martin Grigorov <mg...@apache.org>wrote:
>>
>>> Hi,
>>>
>>> Please create a ticket and attach your quickstart.
>>> It will be good to fix this for 6.5.0 (scheduled for this Friday (Jan
>>> 18)).
>>>
>>>
>>> On Tue, Jan 15, 2013 at 3:18 AM, Jeremy Levy <je...@gmail.com> wrote:
>>>
>>>> I believe I may have stumbled upon somewhat serious issue with 6.4.0
>>> (and
>>>> possibly earlier). A page that is annotated with @RequiresHttps and is
>>>> mounted with any encoding method, when requested directly, or linked to
>>> is
>>>> not switched over to https. If the page is not specifically mounted it
>>>> works as expected.
>>>>
>>>> I was able to recreate this in my application as well as in a standalone
>>>> 'quickstart' project. As far as I could see
>>>> HttpsMapper.getDesiredSchemeFor wasn't even being called for the mounted
>>>> pages.
>>>>
>>>> I'll debug the issue tomorrow and submit a patch if I can figure it out,
>>>> however I thought this was serious enough to bring up here right away.
>>>>
>>>> Jeremy
>>>>
>>>> --
>>>> Jeremy Levy
>>>>
>>>
>>>
>>> --
>>> Martin Grigorov
>>> jWeekend
>>> Training, Consulting, Development
>>> http://jWeekend.com <http://jweekend.com/>
>>>
>>
>>
>> --
>> Jeremy Levy
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: HttpsMapper broken with Mounted pages
Posted by Jeremy Levy <je...@gmail.com>.
Just to close the loop here. If setRootRequestMapper(new HttpsMapper... is
done before you add your mounts, they will not be enabled for SSL. I've
added and updated the Wiki to reflect this as well as requested the line in
the javadoc where this is be mentioned be made more prominent.
Jeremy
On Tue, Jan 15, 2013 at 10:24 AM, Jeremy Levy <je...@gmail.com> wrote:
> Thanks- Done.
>
> https://issues.apache.org/jira/browse/WICKET-4979
>
>
> On Tue, Jan 15, 2013 at 3:05 AM, Martin Grigorov <mg...@apache.org>wrote:
>
>> Hi,
>>
>> Please create a ticket and attach your quickstart.
>> It will be good to fix this for 6.5.0 (scheduled for this Friday (Jan
>> 18)).
>>
>>
>> On Tue, Jan 15, 2013 at 3:18 AM, Jeremy Levy <je...@gmail.com> wrote:
>>
>> > I believe I may have stumbled upon somewhat serious issue with 6.4.0
>> (and
>> > possibly earlier). A page that is annotated with @RequiresHttps and is
>> > mounted with any encoding method, when requested directly, or linked to
>> is
>> > not switched over to https. If the page is not specifically mounted it
>> > works as expected.
>> >
>> > I was able to recreate this in my application as well as in a standalone
>> > 'quickstart' project. As far as I could see
>> > HttpsMapper.getDesiredSchemeFor wasn't even being called for the mounted
>> > pages.
>> >
>> > I'll debug the issue tomorrow and submit a patch if I can figure it out,
>> > however I thought this was serious enough to bring up here right away.
>> >
>> > Jeremy
>> >
>> > --
>> > Jeremy Levy
>> >
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com <http://jweekend.com/>
>>
>
>
>
> --
> Jeremy Levy
>
--
Jeremy Levy
Re: HttpsMapper broken with Mounted pages
Posted by Jeremy Levy <je...@gmail.com>.
Thanks- Done.
https://issues.apache.org/jira/browse/WICKET-4979
On Tue, Jan 15, 2013 at 3:05 AM, Martin Grigorov <mg...@apache.org>wrote:
> Hi,
>
> Please create a ticket and attach your quickstart.
> It will be good to fix this for 6.5.0 (scheduled for this Friday (Jan 18)).
>
>
> On Tue, Jan 15, 2013 at 3:18 AM, Jeremy Levy <je...@gmail.com> wrote:
>
> > I believe I may have stumbled upon somewhat serious issue with 6.4.0 (and
> > possibly earlier). A page that is annotated with @RequiresHttps and is
> > mounted with any encoding method, when requested directly, or linked to
> is
> > not switched over to https. If the page is not specifically mounted it
> > works as expected.
> >
> > I was able to recreate this in my application as well as in a standalone
> > 'quickstart' project. As far as I could see
> > HttpsMapper.getDesiredSchemeFor wasn't even being called for the mounted
> > pages.
> >
> > I'll debug the issue tomorrow and submit a patch if I can figure it out,
> > however I thought this was serious enough to bring up here right away.
> >
> > Jeremy
> >
> > --
> > Jeremy Levy
> >
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com <http://jweekend.com/>
>
--
Jeremy Levy
Re: HttpsMapper broken with Mounted pages
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
Please create a ticket and attach your quickstart.
It will be good to fix this for 6.5.0 (scheduled for this Friday (Jan 18)).
On Tue, Jan 15, 2013 at 3:18 AM, Jeremy Levy <je...@gmail.com> wrote:
> I believe I may have stumbled upon somewhat serious issue with 6.4.0 (and
> possibly earlier). A page that is annotated with @RequiresHttps and is
> mounted with any encoding method, when requested directly, or linked to is
> not switched over to https. If the page is not specifically mounted it
> works as expected.
>
> I was able to recreate this in my application as well as in a standalone
> 'quickstart' project. As far as I could see
> HttpsMapper.getDesiredSchemeFor wasn't even being called for the mounted
> pages.
>
> I'll debug the issue tomorrow and submit a patch if I can figure it out,
> however I thought this was serious enough to bring up here right away.
>
> Jeremy
>
> --
> Jeremy Levy
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com <http://jweekend.com/>