You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/02/17 21:33:29 UTC
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov opened a new pull
request #88: KLL moving merge
AlexanderSaydakov opened a new pull request #88: KLL moving merge
URL: https://github.com/apache/incubator-datasketches-cpp/pull/88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on a change in pull
request #88: KLL moving merge
Posted by GitBox <gi...@apache.org>.
jmalkin commented on a change in pull request #88: KLL moving merge
URL: https://github.com/apache/incubator-datasketches-cpp/pull/88#discussion_r380893354
##########
File path: kll/test/kll_sketch_custom_type_test.cpp
##########
@@ -150,6 +151,17 @@ class kll_sketch_custom_type_test: public CppUnit::TestFixture {
CPPUNIT_ASSERT_EQUAL(sketch1.get_rank(n / 2), sketch2.get_rank(n / 2));
}
+ void moving_merge() {
+ kll_test_type_sketch sketch1(8);
+ for (int i = 0; i < 10; i++) sketch1.update(i);
+ kll_test_type_sketch sketch2(8);
+ sketch2.update(10);
+ sketch2.merge(std::move(sketch1));
Review comment:
this test seems like a good example of where having proper code coverage measures would be useful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin merged pull request #88: KLL
moving merge
Posted by GitBox <gi...@apache.org>.
jmalkin merged pull request #88: KLL moving merge
URL: https://github.com/apache/incubator-datasketches-cpp/pull/88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org