You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2023/01/05 10:58:52 UTC

[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #4105: fix: fix gitlab missing transformation rules

mindlesscloud commented on code in PR #4105:
URL: https://github.com/apache/incubator-devlake/pull/4105#discussion_r1062351673


##########
plugins/gitlab/api/blueprint_v200.go:
##########
@@ -132,6 +132,7 @@ func makePipelinePlanV200(subtaskMetas []core.SubTaskMeta, scopes []*core.Bluepr
 		options := make(map[string]interface{})
 		options["connectionId"] = connection.ID
 		options["projectId"] = intScopeId
+		options["transformationRuleId"] = transformationRules.ID

Review Comment:
   After a discussion with @warren830 , we think it's OK to set `transformationRuleId` to options within the function `makePipelinePlanV200`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org