Re: [PR] refactor(services/http): Move services http out as a crate [opendal]

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #6870:
URL: https://github.com/apache/opendal/pull/6870#discussion_r2596471960


##########
core/core/src/layers/immutable_index.rs:
##########
@@ -211,7 +211,10 @@ impl oio::List for ImmutableDir {
 }
 
 #[cfg(test)]
-#[cfg(feature = "services-http")]
+// Note: services-http feature is now in opendal facade crate, not opendal-core

Review Comment:
   This the case we need to avoid. Can you move this layer out first?



##########
core/core/src/raw/oio/write/api.rs:
##########
@@ -43,7 +43,10 @@ pub trait Write: Unpin + Send + Sync {
 
 impl Write for () {
     async fn write(&mut self, _: Buffer) -> Result<()> {
-        unimplemented!("write is required to be implemented for oio::Write")
+        Err(Error::new(

Review Comment:
   We shouldn't touch unrelated code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org