You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/03/16 21:56:04 UTC
[GitHub] [felix-atomos] stbischof opened a new pull request #15: more
flexible substrate builder
stbischof opened a new pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611213889
This pull request **introduces 3 alerts** and **fixes 3** when merging c51e3b897f6e22eb7616172651e97cfb4dfff910 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-b9ff0bb11a130b9aa1043b155650b41f662c41b4)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] stbischof opened a new pull request #15: more
flexible substrate builder
Posted by GitBox <gi...@apache.org>.
stbischof opened a new pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611231842
This pull request **introduces 3 alerts** and **fixes 3** when merging baf14c47eb1e8306fa180071583994817b66f8e0 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-d494e7e8115f578db2d2bdc009700122da68605f)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611242467
This pull request **introduces 3 alerts** and **fixes 3** when merging b1849f7fd13193db5824e2236409285ecb36d592 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-550da13abede663c7f1b3cf7a6c5c7dcf4f5699c)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-605727426
This pull request **introduces 7 alerts** and **fixes 3** when merging d69d94c7673c3ddec311585f4e06cb4a8a1de561 into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-253494e064f972641f923e263ee3587dacc70189)
**new alerts:**
* 3 for Useless null check
* 2 for Potential input resource leak
* 1 for Container contents are never accessed
* 1 for Inconsistent equals and hashCode
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-605490840
This pull request **introduces 7 alerts** and **fixes 3** when merging 851f3edb641506d9311218a098cb85b4549f0048 into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-b5f3323884f3b7daa65916f3d07e008b2cb5e3cd)
**new alerts:**
* 3 for Useless null check
* 2 for Potential input resource leak
* 1 for Container contents are never accessed
* 1 for Inconsistent equals and hashCode
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611491091
This pull request **introduces 3 alerts** and **fixes 3** when merging dfcec3ae000fc403ea31db86bca24b0eb1c3d00f into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-8d8855047ef263ebc6b8b9baf661207dbcc837cc)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15:
more flexible substrate builder
Posted by GitBox <gi...@apache.org>.
tjwatson commented on a change in pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400366271
##########
File path: atomos.maven/src/main/java/org/apache/felix/atomos/maven/NativeImageMojo.java
##########
@@ -109,78 +86,16 @@ public void execute() throws MojoExecutionException
try
{
Files.createDirectories(outputDirectory.toPath());
-
Config config = new Config();
-
config.additionalInitializeAtBuildTime = additionalInitializeAtBuildTime;
- if (imageName == null || imageName.isEmpty())
Review comment:
I probably don't need to review this just yet. It seems the current state is that the Mojos are not hooked into the utilities yet. The resulting build of atomos.examples.substrate.maven.equinox doesn't produce a native-image yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-608495036
This pull request **introduces 4 alerts** and **fixes 3** when merging 65fc65e2f923d37a220942550e04ac7d0dbc11b4 into 4b0feb8be5351b534f7374d2a750863609d09eb1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-80a1bd1bb797809d5b7c1fb2e88ccd0e7693c396)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Container contents are never accessed
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-610010055
This pull request **introduces 4 alerts** and **fixes 3** when merging 5cdc55e342b4779c25c071d9b3cee3d7184195d0 into 4b0feb8be5351b534f7374d2a750863609d09eb1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-d25822f2f6f4727ca85aef8afc39b5621279f2f4)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Container contents are never accessed
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611481726
This pull request **introduces 3 alerts** and **fixes 3** when merging 6c354c1917d094aa6df1b32c95f0f30da2ad0c81 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-3990e4a1ab9e49a5c10d8032de0b91c06ee2f30d)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15:
more flexible substrate builder
Posted by GitBox <gi...@apache.org>.
tjwatson commented on a change in pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400358972
##########
File path: atomos.maven/src/main/java/org/apache/felix/atomos/maven/AtomosIndexMojo.java
##########
@@ -63,7 +63,7 @@ public void execute() throws MojoExecutionException
AtomosIndexMojo::isJarFile).map(a -> a.getFile().toPath()).collect(
Collectors.toList());
- SubstrateUtil.indexContent(paths, outputDirectory.toPath());
+ // SubstrateUtil.indexContent(paths, outputDirectory.toPath());
Review comment:
I assume this still needs to be reworked to the refactored stuff. I have on my list of things to do is add sniff integration tests to make sure the examples still work. The atomos.examples.index resulting JAR no longer works because the atomos index is no longer written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-605740581
This pull request **introduces 1 alert** and **fixes 3** when merging 9fe1b24bc3ecc1a7eb85ad3b38ca7c51b9c05cfd into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-6a5189c278bce0c037726fdffd0630b4ec9e2271)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611535466
This pull request **introduces 3 alerts** and **fixes 3** when merging 8f2a920b9ebbdc5f116170553c0227693e9de255 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-d2257d69003f6f4ad4bcd5b8583ba4412f3a5c48)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-605736927
This pull request **introduces 1 alert** and **fixes 3** when merging 76e3d789fea185e4206810b092300353d2759682 into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-4bd586dcd5c140fe2f8d2d80fc45e84331606946)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-605734009
This pull request **introduces 1 alert** and **fixes 3** when merging 112e06e7d96b86f369cd08af5821e37dde9c5f11 into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-9498bfa619354138e0a3d2112de1c8ee7b665422)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15:
more flexible substrate builder
Posted by GitBox <gi...@apache.org>.
tjwatson commented on a change in pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400358352
##########
File path: atomos.maven/pom.xml
##########
@@ -9,16 +9,12 @@
<artifactId>org.apache.felix.atomos.maven</artifactId>
Review comment:
Shouldn't the artifact ID also be atomos-maven-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611223682
This pull request **introduces 3 alerts** and **fixes 3** when merging ce7063afb351b0eb476259052b825fea5644a031 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-cb30e42921bb27034decf9b26af8431123932d56)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
tjwatson commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-600250645
Some superficial comments while you are in draft mode on this PR. In the end I think we will want a general plugin that will be able to do substrate stuff, but it may over time provide help building other deployment types other than substrate native-image.
For example, I would like a plugin that can be used to create the Atomos bundles.index and be able to use that to create a flat uber JAR with all the bundles/framework/atomos runtime. With that in mind, if we are going to create a sub module for the maven plugin then I would keep the sub module more general than `atomos.substrate`. I would recommend using a submodule with a name like `atomos.maven.plugin`. I also think the general convention for the artifact ID for maven plugins is to use a dashed `-` name. I recommend for the actual plugin we use an artifact ID like `atomos-maven-plugin` where the GID is `org.apache.felix`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611427567
This pull request **introduces 3 alerts** and **fixes 3** when merging 5ac879f4b2c2040552a207e49cb9f9ae59b64e08 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-454ea8740e27fa675ae6bfe30e0e571282a42105)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson merged pull request #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
tjwatson merged pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] stbischof commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
stbischof commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-600321247
Thank you for the comment. This i why I opend this draft pull request.
You are addressing the right things. I tried to handle it more globally.
E.g.
Collect files from a
- directory
- pom.xml
- feature.xml
Create a native image or generate just the bundles.index
But most of the work is not maven specific.
Maybe for this part is
'atomos-tooling' a better name.
atomos-maven-plugin shut also exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] stbischof commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
stbischof commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611253641
dsff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] stbischof removed a comment on issue #15: more
flexible substrate builder
Posted by GitBox <gi...@apache.org>.
stbischof removed a comment on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611253641
dsff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611259277
This pull request **introduces 3 alerts** and **fixes 3** when merging 91270ac1d1b0ce733d9ab723726d32fcbf650f4f into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-64fbfb3b20b87fe54ac5409917c04384186774e4)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-606517688
This pull request **introduces 2 alerts** and **fixes 3** when merging 648099bffbd54a6c6cfea55d13cbd932e05bbb4f into 58643e07bda46ef677a308007b51e5a5d07ce1d5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-cc69f4a852de712e2348e52eb5164e52e2ea617f)
**new alerts:**
* 1 for Container contents are never accessed
* 1 for Potential input resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611155140
This pull request **introduces 3 alerts** and **fixes 3** when merging 89715aaa65a3c76c5fa5078ede8216edd36bcd16 into ff13b0fa348e32560e44f8722058ce748ffea9a3 - [view on LGTM.com](https://lgtm.com/projects/g/apache/felix-atomos/rev/pr-b169c3638d8170e4043ef44ca29f88c3fc70747c)
**new alerts:**
* 2 for Potential input resource leak
* 1 for Potential output resource leak
**fixed alerts:**
* 2 for Potential input resource leak
* 1 for Arbitrary file write during archive extraction \("Zip Slip"\)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] stbischof closed pull request #15: more flexible
substrate builder
Posted by GitBox <gi...@apache.org>.
stbischof closed pull request #15: more flexible substrate builder
URL: https://github.com/apache/felix-atomos/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services