You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@climate.apache.org by markschn <gi...@git.apache.org> on 2019/01/22 10:16:10 UTC

[GitHub] climate pull request #522: Climate 964

GitHub user markschn opened a pull request:

    https://github.com/apache/climate/pull/522

    Climate 964

    The local model files are not downloaded to the temp directory in Windows since the "tmp" directory was introduced in CLIMATE 603.  In order to make the downloads work on Windows as well as Linux (and Mac), this pull request uses tempfile.gettempdir()  identify the optimal temp file location for that operating system.
    
    I am new to this project so I have not yet run the test suite, though I have tested locally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markschn/climate CLIMATE-964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #522
    
----
commit 28a4593c634af40bf0385a8ae209ac0afa609d69
Author: Mark Schnitzer <ma...@...>
Date:   2019-01-22T01:36:17Z

    added tempfile to get temp directory in example

commit 8d9ef6534bbce700585ca95b247b4fb73debf0d6
Author: Mark Schnitzer <ma...@...>
Date:   2019-01-22T01:49:18Z

    added comment

----


---

[GitHub] climate issue #522: Climate 964

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/climate/pull/522
  
    Thank you @markschn thanks for following up here. 


---

[GitHub] climate pull request #522: Climate 964

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/climate/pull/522


---