You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2017/01/31 19:48:40 UTC
[2/2] kudu git commit: [thirdparty] fix build-thirdparty.sh for bash
3.x
[thirdparty] fix build-thirdparty.sh for bash 3.x
The fall-through directive ';&' works only for bash >= 4.0.
This change makes it work for bash 3.x as well.
Change-Id: I624e5d13b8a981491a65bae590be1f1e432710a9
Reviewed-on: http://gerrit.cloudera.org:8080/5832
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/defd6e83
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/defd6e83
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/defd6e83
Branch: refs/heads/master
Commit: defd6e8316c9c2c28acd8ccf54133a901d155c0f
Parents: d84c35b
Author: Alexey Serbin <as...@cloudera.com>
Authored: Mon Jan 30 22:29:17 2017 -0800
Committer: Dan Burkert <da...@apache.org>
Committed: Tue Jan 31 19:47:12 2017 +0000
----------------------------------------------------------------------
thirdparty/build-thirdparty.sh | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/defd6e83/thirdparty/build-thirdparty.sh
----------------------------------------------------------------------
diff --git a/thirdparty/build-thirdparty.sh b/thirdparty/build-thirdparty.sh
index 6d3bf06..fd7df7b 100755
--- a/thirdparty/build-thirdparty.sh
+++ b/thirdparty/build-thirdparty.sh
@@ -64,13 +64,18 @@ else
for arg in $*; do
case $arg in
# Dependency groups.
- "common") F_COMMON=1 ;;
- "uninstrumented") F_UNINSTRUMENTED=1 ;;
- "tsan") F_TSAN=1 ;;
+ "common") F_COMMON=1
+ continue 1;;
+ "uninstrumented") F_UNINSTRUMENTED=1
+ continue 1;;
+ "tsan") F_TSAN=1
+ continue 1;;
# User requested a specific package to be built.
- *) F_SPECIFIC_PACKAGE=1 ;& # Fall through to below cases.
+ *) F_SPECIFIC_PACKAGE=1 ;; # Go through to the switch below.
+ esac
+ case $arg in
# Dependencies.
"cmake") F_CMAKE=1 ;;
"gflags") F_GFLAGS=1 ;;