You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/24 14:39:00 UTC

[jira] [Commented] (METRON-1058) address checkstyle warnings for UnusedImports in metron-stellar

    [ https://issues.apache.org/jira/browse/METRON-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098500#comment-16098500 ] 

ASF GitHub Bot commented on METRON-1058:
----------------------------------------

GitHub user dbist opened a pull request:

    https://github.com/apache/metron/pull/663

    METRON-1058 address checkstyle warnings for UnusedImports in metron-stellar

    ## Contributor Comments
    [Please place any comments here.  A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dbist/metron METRON-1058

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #663
    
----
commit 0ffc362158966b6d3921e0f165503a3b9b0b8f50
Author: Artem Ervits <ge...@gmail.com>
Date:   2017-07-24T14:01:01Z

    METRON-1058

commit 095cc94159c0a18490e46d8588cfd993574d1537
Author: Artem Ervits <ge...@gmail.com>
Date:   2017-07-24T14:36:22Z

    METRON-1058

----


> address checkstyle warnings for UnusedImports in metron-stellar
> ---------------------------------------------------------------
>
>                 Key: METRON-1058
>                 URL: https://issues.apache.org/jira/browse/METRON-1058
>             Project: Metron
>          Issue Type: Bug
>    Affects Versions: 0.4.1
>         Environment: Mac OSX 10.12.5
> Maven 3.5.0
> JDK 1.8.0_141
>            Reporter: Artem Ervits
>            Priority: Minor
>              Labels: newbie
>             Fix For: Next + 1
>
>         Attachments: METRON-1058-0.patch
>
>
> addressing UnusedImports warning in checkstyle report for metron-stellar



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)