You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rjgoyln (via GitHub)" <gi...@apache.org> on 2026/08/25 12:46:08 UTC
[PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
rjgoyln opened a new pull request, #11111:
URL: https://github.com/apache/ozone/pull/11111
## What changes were proposed in this pull request?
Every Datanode in a mini cluster starts pre-finalized. `MiniOzoneCluster` pre-creates each Datanode's `datanode.id` file — HDDS-14812 added that so a Datanode given a synthetic hostname can report an IP address it has no way to resolve, `ipAddress` being required at registration — and `DatanodeLayoutStorage` reads a `datanode.id` file with no VERSION file beside it as an upgrade from an install predating the upgrade framework, defaulting to metadata layout version 0. The Datanode reaches the current version only once SCM orders it to finalize, after it registers.
Master hides this, because SCM finalizes those Datanodes before they can satisfy safemode and tests wait on them. Under ZDU a pre-finalized Datanode is valid for existing operations and no longer holds up safemode exit, so a write meant for a finalized Datanode can land on one that has not finalized yet — the intermittent `TestFinalizeBlock` failures.
The identity file is now written only for Datanodes that are given a synthetic hostname, with the layout version stamped beside it; every other cluster builds its Datanodes the way a real one does. Tests that want an older layout version set it through `UniformDatanodesFactory`, which writes the VERSION file itself and takes precedence.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16206
## How was this patch tested?
A new parameterized test in `TestMiniOzoneCluster` builds a cluster with its Datanodes not started and asserts the metadata layout version defaults to the maximum, with and without configured hostnames; both cases fail without the change (`expected: <10> but was: <0>`).
`TestRackAwarePlacement` — added with HDDS-14812, covering every rack and hostname combination — and `TestDNDataDistributionFinalization` pass, as does `checkstyle:check` on both modules. `TestHDDSUpgrade` ran out of memory on this machine before finishing, so it is left to CI.
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #11111:
URL: https://github.com/apache/ozone/pull/11111#issuecomment-5420126024
There are actually two workarounds introduced in HDDS-14812:
1. Introduce a custom `CachedDNSToSwitchMapping` to support user-defined hostnames.
2. Pre-create the `datanode.id` YAML file to set the hostname/IP for the DN.
HDDS-16018 addressed (1), so we can remove that workaround now.
However, (2) is still needed for tests using synthetic hostnames, and this issue is related to a side effect introduced by (2). So I don't think we can completely revert the workaround from HDDS-14812 yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11111:
URL: https://github.com/apache/ozone/pull/11111#issuecomment-5820313707
Thanks @rjgoyln for the patch, @errose28, @hevinhsu, @ivandika3 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #11111:
URL: https://github.com/apache/ozone/pull/11111#issuecomment-5411015682
@hevinhsu could you help to check this? We have merged [HDDS-16018](https://issues.apache.org/jira/browse/HDDS-16018) so technically the workaround in HDDS-14812 that is causing this issue is not needed anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11111:
URL: https://github.com/apache/ozone/pull/11111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "rjgoyln (via GitHub)" <gi...@apache.org>.
rjgoyln commented on PR #11111:
URL: https://github.com/apache/ozone/pull/11111#issuecomment-5411360925
> @hevinhsu could you help to check this when you are available? We have merged [HDDS-16018](https://issues.apache.org/jira/browse/HDDS-16018) so technically the workaround in [HDDS-14812](https://issues.apache.org/jira/browse/HDDS-14812) that is causing this issue is not needed anymore? Can we revert the workaround instead?
Thanks for checking! I actually tried reverting it completely at first, but it caused `TestRackAwarePlacement` to fail.
It turns out HDDS-14812 introduced **two** workarounds. While HDDS-16018 fixed the mapping issue, we still need the `datanode.id` file for tests with synthetic hostnames. Without it, DNS lookups fail, causing a missing `ipAddress` error (tracked in [HDDS-16007](https://issues.apache.org/jira/browse/HDDS-16007)).
Therefore, this PR only keeps the file for those specific test cases and cleans up the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16206. Start MiniOzoneCluster Datanodes finalized [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #11111:
URL: https://github.com/apache/ozone/pull/11111#issuecomment-5480730369
Only affecting the topology tests is an improvement. We may get surprised if there is ever a ZDU incompatible change related to topology that we need to integration test but I'm ok with merging this as an improvement for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org