You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/05/05 04:04:52 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6241: refactor: use get_result_type to replace binary_operator_data_type.
jackwener opened a new pull request, #6241:
URL: https://github.com/apache/arrow-datafusion/pull/6241
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
following #6221
# What changes are included in this PR?
- use get_result_type to replace binary_operator_data_type
- fix case in get_result_type
- don't use coerce_type in get_result_type
# Are these changes tested?
# Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6241: refactor: use get_result_type to replace binary_operator_data_type.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6241:
URL: https://github.com/apache/arrow-datafusion/pull/6241#discussion_r1186008426
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -121,6 +60,10 @@ pub fn get_result_type(
| Operator::Gt
| Operator::GtEq
| Operator::LtEq
+ | Operator::RegexMatch
Review Comment:
this is a good change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6241: refactor: use get_result_type to replace binary_operator_data_type.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6241:
URL: https://github.com/apache/arrow-datafusion/pull/6241#issuecomment-1536154082
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6241: refactor: use get_result_type to replace binary_operator_data_type.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6241:
URL: https://github.com/apache/arrow-datafusion/pull/6241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org