You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "momo-jun (via GitHub)" <gi...@apache.org> on 2023/03/23 08:11:29 UTC
[GitHub] [pulsar-site] momo-jun opened a new pull request, #489: [improve][doc] Clarify the scope of delayed msg delivery
momo-jun opened a new pull request, #489:
URL: https://github.com/apache/pulsar-site/pull/489
### Modification
1. Highlight and clarify the scope of delayed msg delivery.
2. Minor fixes and style alignment.
<img width="1396" alt="image" src="https://user-images.githubusercontent.com/60642177/227141439-19dad5f7-9dc1-4cff-81ab-47bbc8d839a2.png">
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #489: [improve][doc] Clarify the scope of delayed msg delivery
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on code in PR #489:
URL: https://github.com/apache/pulsar-site/pull/489#discussion_r1147348523
##########
docs/concepts-messaging.md:
##########
@@ -531,8 +534,7 @@ In the diagram below, **Consumer A**, **Consumer B** and **Consumer C** are all
:::note
-**Limitations of Shared type**
- When using Shared type, be aware that:
+When using Shared type, be aware that:
Review Comment:
I've paraphrased this sentence for simplicity. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet merged pull request #489: [improve][doc] Clarify the scope of delayed msg delivery
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet merged PR #489:
URL: https://github.com/apache/pulsar-site/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #489: [improve][doc] Clarify the scope of delayed msg delivery
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on code in PR #489:
URL: https://github.com/apache/pulsar-site/pull/489#discussion_r1147073378
##########
docs/concepts-messaging.md:
##########
@@ -531,8 +534,7 @@ In the diagram below, **Consumer A**, **Consumer B** and **Consumer C** are all
:::note
-**Limitations of Shared type**
- When using Shared type, be aware that:
+When using Shared type, be aware that:
Review Comment:
Suggest keeping consistent for the line 537 and 748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org