You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2020/12/11 18:36:31 UTC

[commons-math] 01/02: MATH-1565: Add context to "OutOfRangeException" so as to produce a complete message.

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-math.git

commit 323f6d71531599127e3b8edd5e13da2ea2c23c97
Author: Gilles Sadowski <gi...@gmail.com>
AuthorDate: Fri Dec 11 18:34:42 2020 +0100

    MATH-1565: Add context to "OutOfRangeException" so as to produce a complete message.
---
 src/changes/changes.xml                                          | 3 +++
 .../org/apache/commons/math4/exception/OutOfRangeException.java  | 9 +++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 28cd6ba..20379fa 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -54,6 +54,9 @@ If the output is not quite correct, check for invisible trailing spaces!
     </release>
 
     <release version="4.0" date="XXXX-XX-XX" description="">
+      <action dev="erans" type="fix" issue="MATH-1565">
+        Add context to "OutOfRangeException".
+      </action>
       <action dev="erans" type="update" issue="MATH-1562" due-to="Frank Ulbricht">
         Add "Automatic-Module-Name" entry to JAR manifest file.
       </action>
diff --git a/src/main/java/org/apache/commons/math4/exception/OutOfRangeException.java b/src/main/java/org/apache/commons/math4/exception/OutOfRangeException.java
index 4e8dd62..0d6730e 100644
--- a/src/main/java/org/apache/commons/math4/exception/OutOfRangeException.java
+++ b/src/main/java/org/apache/commons/math4/exception/OutOfRangeException.java
@@ -42,7 +42,9 @@ public class OutOfRangeException extends MathIllegalNumberException {
     public OutOfRangeException(Number wrong,
                                Number lo,
                                Number hi) {
-        this(LocalizedFormats.OUT_OF_RANGE_SIMPLE, wrong, lo, hi);
+        super(LocalizedFormats.OUT_OF_RANGE_SIMPLE, wrong, lo, hi);
+        this.lo = lo;
+        this.hi = hi;
     }
 
     /**
@@ -58,9 +60,8 @@ public class OutOfRangeException extends MathIllegalNumberException {
                                Number wrong,
                                Number lo,
                                Number hi) {
-        super(specific, wrong, lo, hi);
-        this.lo = lo;
-        this.hi = hi;
+        this(wrong, lo, hi);
+        getContext().addMessage(specific, wrong, lo, hi);
     }
 
     /**