You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2016/11/02 08:25:58 UTC
[jira] [Updated] (ISIS-909) BookmarksPagesPanel often cannot detect
the current/active model
[ https://issues.apache.org/jira/browse/ISIS-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Haywood updated ISIS-909:
-----------------------------
Fix Version/s: (was: 1.16.0)
1.14.0
> BookmarksPagesPanel often cannot detect the current/active model
> ----------------------------------------------------------------
>
> Key: ISIS-909
> URL: https://issues.apache.org/jira/browse/ISIS-909
> Project: Isis
> Issue Type: Bug
> Components: Core: Viewer: Wicket
> Affects Versions: viewer-wicket-1.6.0
> Reporter: Martin Grigorov
> Assignee: Dan Haywood
> Priority: Minor
> Fix For: 1.14.0
>
>
> There is a logic [1] at BookmarkedPagesPanel.java that tries to detect whether an item in the bookmarks sliding menu is the currently viewed/edited item and sets CSS class "currentBookmark".
> Most of the time bookmarkedPagesModel.isCurrent(pageParameters) doesn't work. It uses Objects.equal(current, pageParameters) and often those have similar oid but additional parameters make the check failing.
> 1. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.java#L167
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)