You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/04 03:14:56 UTC

[GitHub] [spark] WangGuangxin commented on issue #23942: [SPARK-27033][SQL]Add Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn

WangGuangxin commented on issue #23942: [SPARK-27033][SQL]Add Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn
URL: https://github.com/apache/spark/pull/23942#issuecomment-469104056
 
 
   > Hi, @WangGuangxin . Thank you for your first contribution.
   > 
   > * First of all, could you create another file for this optimizer?
   > * Second, could you rename this optimizer name to more specific one? `TransformBinaryComparison` looks too broad claim to me because this optimizer only aims `+/-` on `Int/Long`. It cannot handle `*` and `/` and other many data types.
   
   I renamed it to `RewriteArithmeticFiltersOnIntOrLongColumn` and put it into a single file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org