You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/01/09 15:32:13 UTC
[jira] [Commented] (BOOKKEEPER-540) #stopServingSubscriber when
channel is disconnected.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548538#comment-13548538 ]
Hadoop QA commented on BOOKKEEPER-540:
--------------------------------------
Testing JIRA BOOKKEEPER-540
Patch [BOOKKEEPER-540.patch|https://issues.apache.org/jira/secure/attachment/12563936/BOOKKEEPER-540.patch] downloaded at Wed Jan 9 14:01:24 UTC 2013
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:red}-1 FINDBUGS{color}
. {color:red}-1{color} the patch seems to introduce 1 new Findbugs warning(s) in module(s) [hedwig-server]
{color:green}+1 TESTS{color}
. Tests run: 782
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/226/
> #stopServingSubscriber when channel is disconnected.
> ----------------------------------------------------
>
> Key: BOOKKEEPER-540
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-540
> Project: Bookkeeper
> Issue Type: Improvement
> Components: hedwig-server
> Reporter: Sijie Guo
> Assignee: Fangmin Lv
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-540.patch
>
>
> as BOOKKEEPER-539 and , some test cases failed due to #stopServingSubscriber issue. Although BOOKKEEPER-529 works out a patch to fix such race condition, it would be better to ensure #stopServingSubscriber when channel is disconnected, to avoid other kind of race and also cleanup the memory.
> (I don't mean to block 4.2.0 release, but there are some test cases found failed related #stopServingSubscriber. so it would be better to handle it before 4.2.0)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira