You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jh...@apache.org on 2010/09/26 22:50:50 UTC

svn commit: r1001511 - /spamassassin/trunk/masses/hit-frequencies

Author: jhardin
Date: Sun Sep 26 20:50:50 2010
New Revision: 1001511

URL: http://svn.apache.org/viewvc?rev=1001511&view=rev
Log:
Undo dynamic-cutoff change from rev#998704, there will always be some rule that hits 100% of messages...

Modified:
    spamassassin/trunk/masses/hit-frequencies

Modified: spamassassin/trunk/masses/hit-frequencies
URL: http://svn.apache.org/viewvc/spamassassin/trunk/masses/hit-frequencies?rev=1001511&r1=1001510&r2=1001511&view=diff
==============================================================================
--- spamassassin/trunk/masses/hit-frequencies (original)
+++ spamassassin/trunk/masses/hit-frequencies Sun Sep 26 20:50:50 2010
@@ -851,22 +851,10 @@ sub _print_overlap_ratios {
   }
 
   my %other_type_rules = %$hash_other_type;
-  my $minratio = -1;
 
   foreach my $ratio (sort { $b <=> $a } keys %$hash1) {
     $ratio ||= 0;
-    if ($minratio < 0) {
-        # Adapt reporting cutoff point to actual ratios.
-        # The first (highest) ratio encountered determines reporting cutoff point:
-        # > 20, cutoff is 20% (100%-20%, the vast majority of rules), else
-        # > 10, cutoff is 5% (20%-5%), else
-        # cutoff is 1% (10%-1%)
-        # This will help FP analysis of very-high-S/O rules
-        if ($ratio > 20) {$minratio = 20;}
-        elsif ($ratio > 10) {$minratio = 5;}
-        else {$minratio = 1;}
-    }
-    last if ($ratio < $minratio);       # don't report overlaps below cutoff
+    last if ($ratio < 20);     # 20% cutoff
     my $rules = _prettify_overlap_rules($r1, $hash1->{$ratio});
     next if ($rules eq '');