You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 08:55:46 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

AngersZhuuuu opened a new pull request #32250:
URL: https://github.com/apache/spark/pull/32250


   ### What changes were proposed in this pull request?
   After the PR https://github.com/apache/spark/pull/32209, this should be possible now. 
   We can add test case for ANSI intervals to HiveThriftBinaryServerSuite
   
   ### Why are the changes needed?
   Add more test case 
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Added UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823134873


   **[Test build #137679 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137679/testReport)** for PR 32250 at commit [`b1a81bd`](https://github.com/apache/spark/commit/b1a81bd84452a2f52cd8546e9e3d852d9b4f77db).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823148560






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32250:
URL: https://github.com/apache/spark/pull/32250


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823148559






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823106068


   FYI @MaxGekk You mean add UT like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823142553






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823159245


   +1, LGTM. Merging to master.
   Thank you, @AngersZhuuuu.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823109907


   **[Test build #137679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137679/testReport)** for PR 32250 at commit [`b1a81bd`](https://github.com/apache/spark/commit/b1a81bd84452a2f52cd8546e9e3d852d9b4f77db).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32250: [SPARK-35068][SQL] Add tests for ANSI intervals to HiveThriftBinaryServerSuite

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32250:
URL: https://github.com/apache/spark/pull/32250#issuecomment-823109907


   **[Test build #137679 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137679/testReport)** for PR 32250 at commit [`b1a81bd`](https://github.com/apache/spark/commit/b1a81bd84452a2f52cd8546e9e3d852d9b4f77db).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org