You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/13 15:06:13 UTC
[GitHub] [spark] xwu99 opened a new pull request #27564: [SPARK-30813][ML]
Fix MLlib Matrices.sprand comments
xwu99 opened a new pull request #27564: [SPARK-30813][ML] Fix MLlib Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564
### What changes were proposed in this pull request?
Fix mistakes in comments
### Why are the changes needed?
There are mistakes in comments
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27564: [SPARK-30813][ML] Fix
Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183327
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-585807707
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-585806973
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183749
**[Test build #119146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119146/testReport)** for PR 27564 at commit [`8cb472e`](https://github.com/apache/spark/commit/8cb472e4a558a0cc57ab507d0ff628583125f390).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183965
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593199872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119146/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23888/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #27564: [SPARK-30813][ML] Fix
Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183965
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593199868
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593199868
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183969
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23888/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27564: [SPARK-30813][ML] Fix
Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593199651
**[Test build #119146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119146/testReport)** for PR 27564 at commit [`8cb472e`](https://github.com/apache/spark/commit/8cb472e4a558a0cc57ab507d0ff628583125f390).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#discussion_r378949244
##########
File path: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala
##########
@@ -1103,7 +1103,7 @@ object Matrices {
DenseMatrix.rand(numRows, numCols, rng)
/**
- * Generate a `SparseMatrix` consisting of `i.i.d.` gaussian random numbers.
+ * Generate a `SparseMatrix` consisting of `i.i.d.` uniform random numbers.
Review comment:
Good catch - there's an identical typo in the mllib module's Matrices class too. Can you fix it here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27564:
[SPARK-30813][ML] Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-585807707
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27564: [SPARK-30813][ML] Fix
Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593442604
Merged to master/3.0/2.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593199872
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119146/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27564: [SPARK-30813][ML]
Fix Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-585806973
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27564: [SPARK-30813][ML] Fix
Matrices.sprand comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27564: [SPARK-30813][ML] Fix Matrices.sprand comments
URL: https://github.com/apache/spark/pull/27564#issuecomment-593183749
**[Test build #119146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119146/testReport)** for PR 27564 at commit [`8cb472e`](https://github.com/apache/spark/commit/8cb472e4a558a0cc57ab507d0ff628583125f390).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org