You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2016/06/13 05:06:47 UTC
svn commit: r1748085 - in /poi/trunk/src:
ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java
resources/devtools/findbugs-filters.xml
scratchpad/src/org/apache/poi/hslf/blip/Metafile.java
Author: onealj
Date: Mon Jun 13 05:06:47 2016
New Revision: 1748085
URL: http://svn.apache.org/viewvc?rev=1748085&view=rev
Log:
findbugs: fix URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD warnings
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java
poi/trunk/src/resources/devtools/findbugs-filters.xml
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java?rev=1748085&r1=1748084&r2=1748085&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFLatentStyles.java Mon Jun 13 05:06:47 2016
@@ -19,7 +19,8 @@ package org.apache.poi.xwpf.usermodel;
import org.openxmlformats.schemas.wordprocessingml.x2006.main.CTLatentStyles;
import org.openxmlformats.schemas.wordprocessingml.x2006.main.CTLsdException;
-public class XWPFLatentStyles {
+public class XWPFLatentStyles {
+ // As of 2016-06-10, POI does not contain a LatentStyle class, nor was one included in the patch for bug 48574.
protected XWPFStyles styles; //LatentStyle shall know styles
private CTLatentStyles latentStyles;
Modified: poi/trunk/src/resources/devtools/findbugs-filters.xml
URL: http://svn.apache.org/viewvc/poi/trunk/src/resources/devtools/findbugs-filters.xml?rev=1748085&r1=1748084&r2=1748085&view=diff
==============================================================================
--- poi/trunk/src/resources/devtools/findbugs-filters.xml (original)
+++ poi/trunk/src/resources/devtools/findbugs-filters.xml Mon Jun 13 05:06:47 2016
@@ -64,6 +64,16 @@
<Bug pattern="URF_UNREAD_FIELD" />
<Field name="count2" />
</Match>
+ <Match>
+ <Class name="org.apache.poi.xwpf.usermodel.XWPFLatentStyles"/>
+ <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
+ <Field name="styles" />
+ </Match>
+ <Match>
+ <Class name="org.apache.poi.hslf.blip.Metafile"/>
+ <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD" />
+ <Field name="compression" />
+ </Match>
<!-- invalid performance issues - e.g. see #57840 -->
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java?rev=1748085&r1=1748084&r2=1748085&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java Mon Jun 13 05:06:47 2016
@@ -37,7 +37,7 @@ import org.apache.poi.util.Units;
public abstract class Metafile extends HSLFPictureData {
/**
- * A structure which represents a 34-byte header preceeding the compressed metafile data
+ * A structure which represents a 34-byte header preceding the compressed metafile data
*
* @author Yegor Kozlov
*/
@@ -66,7 +66,7 @@ public abstract class Metafile extends H
/**
* Reserved. Always 0.
*/
- public int compression;
+ public int compression = 0;
/**
* Reserved. Always 254.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org