You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2026/02/12 00:12:27 UTC

[PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

alinaliBQ opened a new pull request, #49251:
URL: https://github.com/apache/arrow/pull/49251

   ### Rationale for this change
   #49250 
   ### What changes are included in this PR?
   - Implement SQLError for macOS
   - Update SQLError related tests for macOS
   
   ### Are these changes tested?
   - SQLError Tests are tested locally on macOS
   
   ### Are there any user-facing changes?
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49251:
URL: https://github.com/apache/arrow/pull/49251#issuecomment-3887924289

   :warning: GitHub issue #49250 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #49251:
URL: https://github.com/apache/arrow/pull/49251#issuecomment-4008345722

   @lidavidm I have rebased this branch onto `main. This PR is ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #49251:
URL: https://github.com/apache/arrow/pull/49251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #49251:
URL: https://github.com/apache/arrow/pull/49251#discussion_r2800768501


##########
cpp/src/arrow/flight/sql/odbc/odbc_api.cc:
##########


Review Comment:
   @lidavidm This draft PR is ready for review, please check the SQLError implementation. This PR needs https://github.com/apache/arrow/pull/49220 to undraft since static ODBC changes `iodbc` behavior and impacts some of SQLError tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-49250: [C++][FlightRPC] ODBC: SQLError for macOS [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49251:
URL: https://github.com/apache/arrow/pull/49251#issuecomment-4010638147

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f83c5541b1198e250f78463b92daabbc2e2b22b3.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/66006074507) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org