You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dzeims <gi...@git.apache.org> on 2014/08/27 20:15:19 UTC
[GitHub] cordova-plugin-file pull request: Possible fix for CB-7415: Implem...
GitHub user dzeims opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/71
Possible fix for CB-7415: Implement a more feature complete implementation of ProgressEvent
* Reuse native ProgressEvent if supported
* Partially or completely pollyfill ProgressEvent if required
* Support assigning the target event property via the event dictionary (needed by File plugin's FileReader/FileWriter.js)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dzeims/cordova-plugin-file master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 0b5013c3d4d1942263c54985cef96b8b99a63266
Author: James White <dz...@users.noreply.github.com>
Date: 2014-08-27T18:00:15Z
Implement a more feature complete implementation of ProgressEvent
* Reuse native ProgressEvent if supported
* Partially or completely pollyfill ProgressEvent if required
* Support assigning the target event property via the event dictionary (needed by File plugin's FileReader/FileWriter.js)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-file pull request: Possible fix for CB-7415: Implem...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/71#issuecomment-58102341
On iOS 6 & 7 (haven't tried 8 yet), I get an error in mobilespec with this patch:
TypeError: Attempting to change access mechanism for an unconfigurable property.
[ProgressEvent.js:102]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Possible fix for CB-7415: Implem...
Posted by dzeims <gi...@git.apache.org>.
Github user dzeims commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/71#issuecomment-59222344
It looked like the version of WebKit used by iOS 6, 7, and BB 10.2.x would throw a TypeError when attempting to redefine the target property on the ProgressEvent. Updated versions of WebKit, as in iOS 8, didn't seem to have this issue. I've updated the code to wrap the affected versions instead. Seems to work on the iOS 6,7 and BB10 devices I've tried.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org