You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/08/15 03:16:25 UTC
[GitHub] [hbase] Apache9 commented on a change in pull request #482:
HBASE-22820 Do not need to persist default rs group now
Apache9 commented on a change in pull request #482: HBASE-22820 Do not need to persist default rs group now
URL: https://github.com/apache/hbase/pull/482#discussion_r314161436
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -456,7 +458,12 @@ private synchronized void flushConfig(Map<String, RSGroupInfo> newGroupMap) thro
// Make changes visible after having been persisted to the source of truth
resetRSGroupMap(newGroupMap);
+ saveRSGroupMapToZK(newGroupMap);
+ updateCacheOfRSGroups(newGroupMap.keySet());
+ }
+
+ public void saveRSGroupMapToZK(Map<String, RSGroupInfo> newGroupMap) throws IOException {
Review comment:
Does this method need to be public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services