You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ranxuxin (via GitHub)" <gi...@apache.org> on 2023/03/07 08:51:54 UTC

[GitHub] [apisix] ranxuxin commented on issue #9007: bug: apisix core dump when receiving grpc client stream

ranxuxin commented on issue #9007:
URL: https://github.com/apache/apisix/issues/9007#issuecomment-1457781507

   @spacewander  Thank to your response. The codes above is the backtrace while I met the core dump. The err variable is not nil. And the err is asserted successfully as the Error type which has GRPCStatus() function. But it cannot guarantee that the status field of Error struct is not nil.  Maybe not all error generated from the package have the non-nil status.
   
   To fix this defect, could we overide the GRPCStatus() function as below?
   
   func (e *Error) GRPCStatus() *Status {
           if e.s == nil {
                 return New(codes.Unknown, err.Error())
           }
   	return e.s
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org