You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/26 05:49:00 UTC
[GitHub] [airflow] milton0825 commented on a change in pull request #5890:
[AIRFLOW-5274] dag loading duration metric name too long
milton0825 commented on a change in pull request #5890: [AIRFLOW-5274] dag loading duration metric name too long
URL: https://github.com/apache/airflow/pull/5890#discussion_r317458205
##########
File path: airflow/models/dagbag.py
##########
@@ -408,13 +405,9 @@ def collect_dags(
self.dagbag_stats = sorted(
stats, key=lambda x: x.duration, reverse=True)
for file_stat in self.dagbag_stats:
- dag_ids = dags_by_name[file_stat.dags]
- if file_stat.dag_num >= 1:
- # if we found multiple dags per file, the stat is 'dag_id1 _ dag_id2'
- dag_names = '_'.join(dag_ids)
- Stats.timing('dag.loading-duration.{}'.
- format(dag_names),
- file_stat.duration)
+ Stats.timing('dag.loading-duration.{}'.
+ format(file_stat.file),
Review comment:
Question: Is `file_stat.file` just the file name or it is the file path that contains `/`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services