You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2016/03/14 06:35:48 UTC
Review Request 44773: Hive View : Upload Table : Tables are not
deleted in case of exception.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44773/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Yusaku Sako.
Bugs: AmbariAMBARI-15392
https://issues.apache.org/jira/browse/AmbariAMBARI-15392
Repository: ambari
Description
-------
Earlier :
In case of error the temporary table and actual table is was not getting cleanedup (deleted).
In this patch:
Now the rollback methods are added to UI which sends proper REST calls to server for deletion of appropriate tables depending on the stage of flow where error occurs.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js 5085cc5
Diff: https://reviews.apache.org/r/44773/diff/
Testing
-------
Manual testing done.
Thanks,
Nitiraj Rathore
Re: Review Request 44773: Hive View : Upload Table : Tables are not
deleted in case of exception.
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44773/#review123976
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On March 14, 2016, 6:16 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44773/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 6:16 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Yusaku Sako.
>
>
> Bugs: AMBARI-15392
> https://issues.apache.org/jira/browse/AMBARI-15392
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earlier :
> In case of error the temporary table and actual table is was not getting cleanedup (deleted).
>
> In this patch:
> Now the rollback methods are added to UI which sends proper REST calls to server for deletion of appropriate tables depending on the stage of flow where error occurs.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js 5085cc5
>
> Diff: https://reviews.apache.org/r/44773/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 44773: Hive View : Upload Table : Tables are not
deleted in case of exception.
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44773/#review123385
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On March 14, 2016, 6:16 a.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44773/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 6:16 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Yusaku Sako.
>
>
> Bugs: AMBARI-15392
> https://issues.apache.org/jira/browse/AMBARI-15392
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earlier :
> In case of error the temporary table and actual table is was not getting cleanedup (deleted).
>
> In this patch:
> Now the rollback methods are added to UI which sends proper REST calls to server for deletion of appropriate tables depending on the stage of flow where error occurs.
>
>
> Diffs
> -----
>
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js 5085cc5
>
> Diff: https://reviews.apache.org/r/44773/diff/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 44773: Hive View : Upload Table : Tables are not
deleted in case of exception.
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44773/
-----------------------------------------------------------
(Updated March 14, 2016, 6:16 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Yusaku Sako.
Changes
-------
corrected the Ambari bug id in the comments of diff file.
Bugs: AMBARI-15392
https://issues.apache.org/jira/browse/AMBARI-15392
Repository: ambari
Description
-------
Earlier :
In case of error the temporary table and actual table is was not getting cleanedup (deleted).
In this patch:
Now the rollback methods are added to UI which sends proper REST calls to server for deletion of appropriate tables depending on the stage of flow where error occurs.
Diffs (updated)
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js 5085cc5
Diff: https://reviews.apache.org/r/44773/diff/
Testing
-------
Manual testing done.
Thanks,
Nitiraj Rathore
Re: Review Request 44773: Hive View : Upload Table : Tables are not
deleted in case of exception.
Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44773/
-----------------------------------------------------------
(Updated March 14, 2016, 6:09 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Yusaku Sako.
Changes
-------
updated Bugs field
Bugs: AMBARI-15392
https://issues.apache.org/jira/browse/AMBARI-15392
Repository: ambari
Description
-------
Earlier :
In case of error the temporary table and actual table is was not getting cleanedup (deleted).
In this patch:
Now the rollback methods are added to UI which sends proper REST calls to server for deletion of appropriate tables depending on the stage of flow where error occurs.
Diffs
-----
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js 5085cc5
Diff: https://reviews.apache.org/r/44773/diff/
Testing
-------
Manual testing done.
Thanks,
Nitiraj Rathore