You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/07/22 22:30:58 UTC

[GitHub] rhtyd commented on a change in pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

rhtyd commented on a change in pull request #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#discussion_r128906265
 
 

 ##########
 File path: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java
 ##########
 @@ -35,7 +35,7 @@
 public class SecurityGroupRulesCmd extends Command {
     private static final String CIDR_LENGTH_SEPARATOR = "/";
     private static final char RULE_TARGET_SEPARATOR = ',';
-    private static final char RULE_COMMAND_SEPARATOR = ':';
+    private static final char RULE_COMMAND_SEPARATOR = ';';
 
 Review comment:
   @wido can changing the separator cause issues (upgrade issues) for existing environments?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services