[GitHub] [couchdb] garrensmith commented on a change in pull request #2066: Prototype/fdb all dbs all docs qs params

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #2066: Prototype/fdb all dbs all docs qs params
URL: https://github.com/apache/couchdb/pull/2066#discussion_r300985444
 
 

 ##########
 File path: src/chttpd/src/chttpd_misc.erl
 ##########
 @@ -108,39 +108,57 @@ maybe_add_csp_headers(Headers, _) ->
     Headers.
 
 handle_all_dbs_req(#httpd{method='GET'}=Req) ->
-    % TODO: Support args and options properly, transform
-    % this back into a fold call similar to the old
-    % version.
-    %% Args = couch_mrview_http:parse_params(Req, undefined),
+    #mrargs{
+        start_key = StartKey,
+        end_key = EndKey,
+        direction = Dir,
+        limit = Limit,
+        skip = Skip
+    } = couch_mrview_http:parse_params(Req, undefined),
 
 Review comment:
   I think we should move the parse_params out of `couch_mrview` and into fabric2 since we need to use it here and for views. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services