You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/07 16:16:56 UTC
[GitHub] [pulsar] teabot opened a new pull request, #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
teabot opened a new pull request, #16451:
URL: https://github.com/apache/pulsar/pull/16451
### Motivation
To reduce warnings generated during compilation by cleaning up the code.
### Modifications
* Moved `return` from `finally` blocks
* Simplified code through the use of simpler, equivalent language constructs
* Made some constant fields `final`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
Non functional change
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] teabot commented on pull request #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
Posted by GitBox <gi...@apache.org>.
teabot commented on PR #16451:
URL: https://github.com/apache/pulsar/pull/16451#issuecomment-1180328635
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a diff in pull request #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
Posted by GitBox <gi...@apache.org>.
merlimat commented on code in PR #16451:
URL: https://github.com/apache/pulsar/pull/16451#discussion_r919525561
##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java:
##########
@@ -7,7 +7,7 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
I think this is making the license check to fail
```suggestion
* http://www.apache.org/licenses/LICENSE-2.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] teabot commented on pull request #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
Posted by GitBox <gi...@apache.org>.
teabot commented on PR #16451:
URL: https://github.com/apache/pulsar/pull/16451#issuecomment-1210620426
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on PR #16451:
URL: https://github.com/apache/pulsar/pull/16451#issuecomment-1182661343
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap merged pull request #16451: [cleanup][pulsar-functions] Remove compiler warnings for return from finally
Posted by GitBox <gi...@apache.org>.
zymap merged PR #16451:
URL: https://github.com/apache/pulsar/pull/16451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org