You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 15:28:14 UTC

[GitHub] [airflow] zachliu commented on a change in pull request #14366: Add total_entries property in ConnectionCollection

zachliu commented on a change in pull request #14366:
URL: https://github.com/apache/airflow/pull/14366#discussion_r581134349



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1425,6 +1425,8 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/ConnectionCollectionItem'
+        total_entries:
+          type: integer

Review comment:
       `allOf` is always a headache in openapi 3.0, but surprisingly this one works 
   my guess is because `CollectionInfo` is not nullable otherwise we are [doomed](https://github.com/OAI/OpenAPI-Specification/issues/1368) :joy: 
   i'll add the rest, thanks :+1:




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org