You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/31 10:05:57 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6911: [AIRFLOW-6353] security - ui - add click jacking defence

mik-laj commented on a change in pull request #6911: [AIRFLOW-6353] security - ui - add click jacking defence
URL: https://github.com/apache/airflow/pull/6911#discussion_r362186185
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -362,6 +362,9 @@ cookie_samesite =
 # Default setting for wrap toggle on DAG code and TI log views.
 default_wrap = False
 
+# Allow the UI to be rendered in a frame
 
 Review comment:
   Hi. Can you add some documentation? I think that a short description in the security.rst file was enough. Very few people will use this feature without documentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services