You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "tsekityam (via GitHub)" <gi...@apache.org> on 2025/03/19 22:34:03 UTC
[PR] [spark connector] allow setting authorization to request header [pinot]
tsekityam opened a new pull request, #15315:
URL: https://github.com/apache/pinot/pull/15315
This PR is used to fix #15300
## What this PR do?
Add an spark connector option `authorization`, to allow user to set authorization header. If the option is set, the value will be set as header while sending request to pinot endpoint
## Before this PR
I have a pinot instance in startree, and the endpoint of my instance is protected by authorization. When I tried to use pinot-spark-3-connector to fetch data from pinot to databricks, with the following code
```scala
var df = spark
.read
.format("pinot")
.option("controller", "xxxxx")
.option("broker", "xxxxx")
.option("table", "xxxxx")
.option("tableType", "hybrid")
.option("useGrpcServer", "true")
.option("usePushDownFilters", "true")
.load()
display(df)
```
I saw this error
```
com.databricks.backend.daemon.driver.scalakernel.SparkException: An error occurred while getting Pinot schema for table 'xxxxxx'
```
## After this PR
I used the following code to fetch the data from pinot to databricks
```py
df = (
spark
.read
.format("pinot")
.option("controller", "xxxxx")
.option("broker", "xxxxx)
.option("table", "xxxxx")
.option("tableType", "offline")
.option("authorization", "Basic xxxxx")
.load()
)
display(df)
```
I can now get the schema from the `table/schema` endpoint, instance info from `/instances` endpoint, routing table from `debug/routingTable/sql` endpoint.
## Note
However, my spark job still failed at the end because dependency issue same as https://github.com/typelevel/cats/issues/3628 and I am working on another PR to replace the `cats` library with `jackson`.
Given that the dependency issue is not part of #15300, I will raise another issue and PR about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [spark connector] allow setting authorization to request header [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed pull request #15315: [spark connector] allow setting authorization to request header
URL: https://github.com/apache/pinot/pull/15315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [spark connector] allow setting authorization to request header [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #15315:
URL: https://github.com/apache/pinot/pull/15315#issuecomment-4113394821
done by https://github.com/apache/pinot/pull/16666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [spark connector] allow setting authorization to request header [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15315:
URL: https://github.com/apache/pinot/pull/15315#issuecomment-2741936248
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15315?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 56.00%. Comparing base [(`59551e4`)](https://app.codecov.io/gh/apache/pinot/commit/59551e45224f1535c4863fd577622b37366ccc97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b5a4433`)](https://app.codecov.io/gh/apache/pinot/commit/b5a44339440766cdfb467a44259713d3ff847e0a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1889 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (59551e4) and HEAD (b5a4433). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (59551e4) | HEAD (b5a4433) |
>|------|------|------|
>|integration|7|0|
>|integration2|3|0|
>|temurin|12|2|
>|java-21|7|2|
>|skip-bytebuffers-true|3|1|
>|skip-bytebuffers-false|7|1|
>|unittests|5|2|
>|java-11|5|0|
>|unittests2|3|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #15315 +/- ##
============================================
- Coverage 61.75% 56.00% -5.75%
- Complexity 207 685 +478
============================================
Files 2436 2174 -262
Lines 133233 117274 -15959
Branches 20636 18750 -1886
============================================
- Hits 82274 65680 -16594
- Misses 44911 46192 +1281
+ Partials 6048 5402 -646
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.00% <ø> (-5.62%)` | :arrow_down: |
| [skip-bytebuffers-false](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.97% <ø> (-5.78%)` | :arrow_down: |
| [skip-bytebuffers-true](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.98% <ø> (+28.25%)` | :arrow_up: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.00% <ø> (-5.75%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.00% <ø> (-5.75%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.00% <ø> (+9.11%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/15315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/15315?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org