[GitHub] [kafka] LinShunKang commented on a diff in pull request #12545: KIP-863: Reduce Fetcher#parseRecord() memory copy

["LinShunKang (via GitHub)" <gi...@apache.org>]

LinShunKang commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1161224453


##########
clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java:
##########
@@ -27,27 +30,45 @@
  *  value.deserializer.encoding or deserializer.encoding. The first two take precedence over the last.
  */
 public class StringDeserializer implements Deserializer<String> {
+

Review Comment:
   > We don't really have a rule for this. It's usually best practice to avoid changing a lot of spacing in a PR (if it's not required) to reduce noise.
   
   Ok, I got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org