[jira] [Commented] (DERBY-6246) convert i18n/urlLocale.sql to JUnit

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676927#comment-13676927 ] 

Knut Anders Hatlen commented on DERBY-6246:
-------------------------------------------

Hi Kathey,

The new test looks fine to me. Some small nits:

Maybe the call to shutdownEngine() could be placed in tearDown() instead of in a finally block, so that errors during engine shutdown won't shadow failures earlier in the test?

And it might be better to use SupportFilesSetup.getReadWrite() instead of hard-coding the path to ../extinout.

All @throws and @param tags in the javadoc comments are empty, so you might just as well remove them.

Thanks.
                
> convert i18n/urlLocale.sql  to JUnit
> ------------------------------------
>
>                 Key: DERBY-6246
>                 URL: https://issues.apache.org/jira/browse/DERBY-6246
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.10.1.1
>            Reporter: Kathey Marsden
>         Attachments: derby-6246_diff.txt
>
>
> Convert i18n/urlLocale.sql to JUnit so that it passes on z/os.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira