You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by qiao wen <31...@qq.com> on 2016/07/18 13:49:54 UTC
Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-2955
https://issues.apache.org/jira/browse/FLUME-2955
Repository: flume-git
Description
-------
Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
Diffs
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
Diff: https://reviews.apache.org/r/50134/diff/
Testing
-------
mvn clean install -DskipTests -> built
junit tests for flume-taildir-source module -> passed
Thanks,
qiao wen
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Denes Arvay <de...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142561
-----------------------------------------------------------
flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1137)
<https://reviews.apache.org/r/50134/#comment208183>
I think `fileHeader` would be a better name for this to be consistent with the `SpoolDirectorySource`.
And speaking of consistency it might be worth to add `fileHeaderKey` too.
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 67)
<https://reviews.apache.org/r/50134/#comment208190>
line is longer than 100 characters
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 198)
<https://reviews.apache.org/r/50134/#comment208184>
- formatting: a space is missing after if
- also please remove the unnecessary `== true`
- the redundant parentheses around `headers != null && !headers.isEmpty()` can be removed too, I'm not sure whether it makes it easier to understand
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 200)
<https://reviews.apache.org/r/50134/#comment208185>
unnecessary extra pair of parenthesis
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 204)
<https://reviews.apache.org/r/50134/#comment208189>
line is too long (107 chars)
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java (line 43)
<https://reviews.apache.org/r/50134/#comment208191>
please remove `.*` import
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java (lines 320 - 322)
<https://reviews.apache.org/r/50134/#comment208188>
it'd be better to use `{f1,f2,f3}.getAbsolutePath()` instead of `tmpDir.getAbsolutePath()+"/file{1,2,3}"`
- Denes Arvay
On July 18, 2016, 1:49 p.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 18, 2016, 1:49 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Denes Arvay <de...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142750
-----------------------------------------------------------
Fix it, then Ship it!
I had one comment, otherwise +1, ship it!
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 302)
<https://reviews.apache.org/r/50134/#comment208376>
I don't see the added value of having a `Boolean` instead of `boolean` here but it introduces a possible `NPEx` in line 350
Could you please change it back to `boolean`?
Otherwise +1 and thanks for the changes.
- Denes Arvay
On July 19, 2016, 3 a.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 3 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Alexander Alten-Lorenz <al...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142734
-----------------------------------------------------------
Ship it!
+1 from me
- Alexander Alten-Lorenz
On July 19, 2016, 3 a.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 3 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Mike Percy <mp...@apache.org>.
> On July 19, 2016, 8:55 p.m., Mike Percy wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java, line 206
> > <https://reviews.apache.org/r/50134/diff/3/?file=1447305#file1447305line206>
> >
> > Can we put this if statement in the above loop, right under line 203, to avoid looping over all of the events twice?
> >
> > Hotspot should optimize-out the branches (and probably even the loop when everything is disabled) so I think we will get better performance in general.
> >
> > So it would look like:
> >
> > // Add headers to each event as needed.
> > Map<String, String> headers = currentFile.getHeaders();
> > for (Event event : events) {
> > if (headers != null && !headers.isEmpty()) {
> > event.getHeaders().putAll(headers);
> > }
> > if (annotateFileName) {
> > String filename = currentFile.getPath();
> > event.getHeaders().put(fileNameHeader, filename);
> > }
> > }
>
> qiao wen wrote:
> Thanks. If headers==null && annotateFileName==false, the program will execute events.size() times. So I think the following will get better performance:
>
> if (annotateFileName || (headers != null && !headers.isEmpty())) {
> for (Event event : events) {
> if (headers != null && !headers.isEmpty()) {
> event.getHeaders().putAll(headers);
> }
> if (annotateFileName) {
> event.getHeaders().put(fileNameHeader, currentFile.getPath());
> }
> }
> }
Even better.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142898
-----------------------------------------------------------
On July 20, 2016, 2:18 a.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 20, 2016, 2:18 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst d8bfebf
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by qiao wen <31...@qq.com>.
> On \u4e03\u6708 20, 2016, 3:55 a.m., Mike Percy wrote:
> > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java, line 206
> > <https://reviews.apache.org/r/50134/diff/3/?file=1447305#file1447305line206>
> >
> > Can we put this if statement in the above loop, right under line 203, to avoid looping over all of the events twice?
> >
> > Hotspot should optimize-out the branches (and probably even the loop when everything is disabled) so I think we will get better performance in general.
> >
> > So it would look like:
> >
> > // Add headers to each event as needed.
> > Map<String, String> headers = currentFile.getHeaders();
> > for (Event event : events) {
> > if (headers != null && !headers.isEmpty()) {
> > event.getHeaders().putAll(headers);
> > }
> > if (annotateFileName) {
> > String filename = currentFile.getPath();
> > event.getHeaders().put(fileNameHeader, filename);
> > }
> > }
Thanks. If headers==null && annotateFileName==false, the program will execute events.size() times. So I think the following will get better performance:
if (annotateFileName || (headers != null && !headers.isEmpty())) {
for (Event event : events) {
if (headers != null && !headers.isEmpty()) {
event.getHeaders().putAll(headers);
}
if (annotateFileName) {
event.getHeaders().put(fileNameHeader, currentFile.getPath());
}
}
}
> On \u4e03\u6708 20, 2016, 3:55 a.m., Mike Percy wrote:
> > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java, line 49
> > <https://reviews.apache.org/r/50134/diff/3/?file=1447308#file1447308line49>
> >
> > It is allowed to have long lines that are imports. No need to wrap this one. (Usually, though, you need to wrap long lines.)
In order to be consistent with the following import appeared before?I wrap that one.
import static org.apache.flume.source.taildir.TaildirSourceConfigurationConstants
.FILE_GROUPS_PREFIX;
- qiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142898
-----------------------------------------------------------
On \u4e03\u6708 19, 2016, 3:09 p.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated \u4e03\u6708 19, 2016, 3:09 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142898
-----------------------------------------------------------
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java (line 206)
<https://reviews.apache.org/r/50134/#comment208561>
Can we put this if statement in the above loop, right under line 203, to avoid looping over all of the events twice?
Hotspot should optimize-out the branches (and probably even the loop when everything is disabled) so I think we will get better performance in general.
So it would look like:
// Add headers to each event as needed.
Map<String, String> headers = currentFile.getHeaders();
for (Event event : events) {
if (headers != null && !headers.isEmpty()) {
event.getHeaders().putAll(headers);
}
if (annotateFileName) {
String filename = currentFile.getPath();
event.getHeaders().put(fileNameHeader, filename);
}
}
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java (line 49)
<https://reviews.apache.org/r/50134/#comment208564>
It is allowed to have long lines that are imports. No need to wrap this one. (Usually, though, you need to wrap long lines.)
- Mike Percy
On July 19, 2016, 8:09 a.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 19, 2016, 8:09 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142980
-----------------------------------------------------------
Ship it!
Ship It!
- Mike Percy
On July 20, 2016, 2:18 a.m., qiao wen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
>
> (Updated July 20, 2016, 2:18 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2955
> https://issues.apache.org/jira/browse/FLUME-2955
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
>
>
> Diffs
> -----
>
> flume-ng-doc/sphinx/FlumeUserGuide.rst d8bfebf
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
> flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
> flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
>
> Diff: https://reviews.apache.org/r/50134/diff/
>
>
> Testing
> -------
>
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
>
>
> Thanks,
>
> qiao wen
>
>
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by qiao wen <31...@qq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/
-----------------------------------------------------------
(Updated \u4e03\u6708 20, 2016, 9:18 a.m.)
Review request for Flume.
Changes
-------
Improve the performace of two for cycle in ReliableTaildirEventReader.java
Bugs: FLUME-2955
https://issues.apache.org/jira/browse/FLUME-2955
Repository: flume-git
Description
-------
Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst d8bfebf
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
Diff: https://reviews.apache.org/r/50134/diff/
Testing
-------
mvn clean install -DskipTests -> built
junit tests for flume-taildir-source module -> passed
Thanks,
qiao wen
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by qiao wen <31...@qq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/
-----------------------------------------------------------
(Updated \u4e03\u6708 19, 2016, 3:09 p.m.)
Review request for Flume.
Changes
-------
Change Boolean to boolean.
Bugs: FLUME-2955
https://issues.apache.org/jira/browse/FLUME-2955
Repository: flume-git
Description
-------
Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
Diff: https://reviews.apache.org/r/50134/diff/
Testing
-------
mvn clean install -DskipTests -> built
junit tests for flume-taildir-source module -> passed
Thanks,
qiao wen
Re: Review Request 50134: FLUME-2955:Add file path to the header in
TaildirSource
Posted by qiao wen <31...@qq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/
-----------------------------------------------------------
(Updated \u4e03\u6708 19, 2016, 3 a.m.)
Review request for Flume.
Changes
-------
According to Denes Arvay's suggestion, add fileHeader and fileHeaderKey parameters like SpoolDirectorySource.
Bugs: FLUME-2955
https://issues.apache.org/jira/browse/FLUME-2955
Repository: flume-git
Description
-------
Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants. If the parameter is true, the file path will be added to the header of flume event. Defaut value is false.
Diffs (updated)
-----
flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 1409f25
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java eae1b1a
flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java 2c49540
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java e090b74
Diff: https://reviews.apache.org/r/50134/diff/
Testing
-------
mvn clean install -DskipTests -> built
junit tests for flume-taildir-source module -> passed
Thanks,
qiao wen