You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/19 08:46:13 UTC
[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request, #4010: Print stack trace in onError method
cxzl25 opened a new pull request, #4010:
URL: https://github.com/apache/incubator-kyuubi/pull/4010
### _Why are the changes needed?_
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #4010: Print stack trace in `KyuubiOperation#onError` method
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #4010: Print stack trace in `KyuubiOperation#onError` method
URL: https://github.com/apache/incubator-kyuubi/pull/4010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #4010: Print stack trace in `KyuubiOperation#onError` method
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4010:
URL: https://github.com/apache/incubator-kyuubi/pull/4010#discussion_r1051954288
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -57,7 +57,7 @@ abstract class KyuubiOperation(session: Session) extends AbstractOperation(sessi
case e: Throwable =>
state.synchronized {
if (isTerminalState(state)) {
- warn(s"Ignore exception in terminal state with $statementId: $e")
Review Comment:
I'm not sure if it's by design, because we just ignore the exception here. but i'm fine w/ this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #4010: Print stack trace in `KyuubiOperation#onError` method
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4010:
URL: https://github.com/apache/incubator-kyuubi/pull/4010#issuecomment-1357905720
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #4010: Print stack trace in `KyuubiOperation#onError` method
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #4010:
URL: https://github.com/apache/incubator-kyuubi/pull/4010#discussion_r1051942079
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperation.scala:
##########
@@ -57,7 +57,7 @@ abstract class KyuubiOperation(session: Session) extends AbstractOperation(sessi
case e: Throwable =>
state.synchronized {
if (isTerminalState(state)) {
- warn(s"Ignore exception in terminal state with $statementId: $e")
Review Comment:
"$e" only get message
```
22/12/19 10:31:24,012 [KyuubiSessionManager-exec-pool: Thread-91361] WARN ExecuteStatement: Ignore exception in terminal state with a3b609f4-1654-4f5a-87d8-8864036df21a: org.apache.thrift.transport.TTransportException: java.net.SocketException: Socket closed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org