You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 18:30:18 UTC

[GitHub] [beam] je-ik edited a comment on pull request #12551: [DISCUSS] {BEAM-10691] keep track of timers creating watermark hold

je-ik edited a comment on pull request #12551:
URL: https://github.com/apache/beam/pull/12551#issuecomment-673037113


   Hi @mxm, can you please help me elaborate on this? This PR fixes issue I noticed, but I'm not sure, why there seems to be timers that are not cleared from the original queue. Moreover, I'm not sure, why there can be null value in the new map (see FIXME in the code). With the precondition check some validatesRunner tests fail.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org