You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/09 17:06:30 UTC
[GitHub] [airflow] potiuk opened a new pull request #8234: Install airflow
version works on Mac and is better organized
potiuk opened a new pull request #8234: Install airflow version works on Mac and is better organized
URL: https://github.com/apache/airflow/pull/8234
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8234: Docker image build
include now releses 1.10.10 version
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8234: Docker image build include now releses 1.10.10 version
URL: https://github.com/apache/airflow/pull/8234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #8234: Docker image
build include now releses 1.10.10 version
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #8234: Docker image build include now releses 1.10.10 version
URL: https://github.com/apache/airflow/pull/8234#issuecomment-611951502
@kaxil @feluelle @ashb @dimberman -> this is a change in the image that includes released 1.10.10 version. I included few simplifications:
- during the build it is auto-detected if yarn packages need to be build (depends on presence of package.json in either www or www_rbac dir). It will build as needed - so if we install from pip, it will not be built at all and if it is installed from GitHub reference or sources it will build the packages. Thanks to that I removed the misleading "AIRFLOW_WWW" arg.
- I replace AIRFLOW_SOURCES_FROM/AIRFLOW_SOURCES_TO to use entrypoint.sh for building from remote location. This will help @dimberman (and in the future) to iterate with Dockerfile for helm chart. You can re-run now :
`./breeze --production-image build-image --install-airflow-version=1.10.10 --use-local-cache ` and as long as you do not touch entrypoint.sh, it will continue using cached build layers without reinstalling Airflow. This is nice for future Development. It also does not copy Dockerfile to inside the image @ashb - it was your comment previously
I am using this Commit to build and push 1.10.10 official image (and I will later automate it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8234: Docker image build
include now releses 1.10.10 version
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8234: Docker image build include now releses 1.10.10 version
URL: https://github.com/apache/airflow/pull/8234#issuecomment-611951502
@kaxil @feluelle @ashb @dimberman -> this is a change in the image that includes released 1.10.10 version. I included few simplifications:
- during the build it is auto-detected if yarn packages need to be build (depends on presence of package.json in either www or www_rbac dir). It will build as needed - so if we install from pip, it will not be built at all and if it is installed from GitHub reference or sources it will build the packages. Thanks to that I removed the misleading "AIRFLOW_WWW" arg.
- I replace AIRFLOW_SOURCES_FROM/AIRFLOW_SOURCES_TO to use entrypoint.sh for building from remote location. This will help @dimberman (and in the future) to iterate with Dockerfile for helm chart. You can run now:
`./breeze --production-image build-image --install-airflow-version=1.10.10 and as long as you do not touch entrypoint.sh, it will continue using cached build layers without reinstalling Airflow. This is nice for future Development. It also does not copy Dockerfile to inside the image @ashb - it was your comment previously
I am using this Commit to build and push 1.10.10 official image (and I will later automate it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #8234: Docker image
build include now releses 1.10.10 version
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #8234: Docker image build include now releses 1.10.10 version
URL: https://github.com/apache/airflow/pull/8234#issuecomment-611951502
@kaxil @feluelle @ashb @dimberman -> this is a change in the image that includes released 1.10.10 version. I included few simplifications:
- during the build it is auto-detected if yarn packages need to be build (depends on presence of package.json in either www or www_rbac dir). It will build as needed - so if we install from pip, it will not be built at all and if it is installed from GitHub reference or sources it will build the packages. Thanks to that I removed the misleading "AIRFLOW_WWW" arg.
- I replace AIRFLOW_SOURCES_FROM/AIRFLOW_SOURCES_TO to use entrypoint.sh for building from remote location. This will help @dimberman (and in the future) to iterate with Dockerfile for helm chart. You can re-run now :
`./breeze --production-image build-image --install-airflow-version=1.10.10 --use-local-cache ` and as long as you do not touch entrypoint.sh, it will continue using cached build layers without reinstalling Airflow. This is nice for future Development and Adding more things to Dockerfile after installation of Airflow. It also does not copy Dockerfile to inside the image @ashb - it was your comment previously
I am using this Commit to build and push 1.10.10 official image (and I will later automate it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #8234: Docker image
build include now releses 1.10.10 version
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #8234: Docker image build include now releses 1.10.10 version
URL: https://github.com/apache/airflow/pull/8234#issuecomment-611951502
@kaxil @feluelle @ashb @dimberman -> this is a change in the image that includes released 1.10.10 version. I included few simplifications:
- during the build it is auto-detected if yarn packages need to be build (depends on presence of package.json in either www or www_rbac dir). It will build as needed - so if we install from pip, it will not be built at all and if it is installed from GitHub reference or sources it will build the packages. Thanks to that I removed the misleading "AIRFLOW_WWW" arg.
- I replaced AIRFLOW_SOURCES_FROM/AIRFLOW_SOURCES_TO to use entrypoint.sh for building from remote location. This will help @dimberman (and in the future) to iterate with Dockerfile for helm chart. You can re-run now :
`./breeze --production-image build-image --install-airflow-version=1.10.10 --use-local-cache ` and as long as you do not touch entrypoint.sh, it will continue using cached build layers without reinstalling Airflow. This is nice for future Development and Adding more things to Dockerfile after installation of Airflow. It also does not copy Dockerfile to inside the image @ashb - it was your comment previously
I am using this Commit to build and push 1.10.10 official image (and I will later automate it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services