[GitHub] [doris] yiguolei commented on a diff in pull request #14744: [Enhancement](status) Unify error code and enable customed err msg for BE internal errors

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #14744:
URL: https://github.com/apache/doris/pull/14744#discussion_r1037730577


##########
be/src/common/daemon.cpp:
##########
@@ -408,20 +408,20 @@ void Daemon::start() {
     st = Thread::create(
             "Daemon", "tcmalloc_gc_thread", [this]() { this->tcmalloc_gc_thread(); },
             &_tcmalloc_gc_thread);
-    CHECK(st.ok()) << st.to_string();
+    CHECK(st.ok()) << st;

Review Comment:
   Could we add another MACRO like CHECK(STATUS), IF STATUS not ok, just print statck error stack inside the marco.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org